[ofw] RE: [PATCH] [ib-diag] ibstat: port_dump is called too many times

Sean Hefty sean.hefty at intel.com
Fri Mar 6 10:03:04 PST 2009


>> -	for (portnum = 0; portnum <= ca.numports; portnum++)
>> +	for (portnum = 0; portnum < ca.numports; portnum++)
>>  		port_dump(ca.ports[portnum], 0);
>
>As expected on linux it shows only first port of two ports CA.

Correct - port_dump checks for NULL ports and returns.  This patch does break
Linux.

>Likely we have libibumad implemented differently in this part.

In libibumad, is umad_ca_t:ports[0] ever not NULL?

- Sean




More information about the ofw mailing list