[ofw] RE: [PATCH-3/3] [QLGCVNIC KERNEL] Expose vendor defined device in ibiou

[Alex Estrin]

Hi Deepak,

Patch looks fine, although there are couple things worth mentioning:
- Number of instances per IOC is limited to 256 ( CMD_INIT packet inicInstance field is 8 bit size), 
so I would add limit check and fail while initialize viport. Before it goes on a wire and gateway fail connection.
- Instances counting is started from '1', while zero is also valid number.

Thanks,
Alex.

> -----Original Message-----
> From: mailmeatdkg at gmail.com [mailto:mailmeatdkg at gmail.com] On Behalf Of Deepak Gupta
> Sent: Friday, March 13, 2009 9:14 AM
> To: ofw at lists.openfabrics.org; Alex Estrin
> Subject: [PATCH-3/3] [QLGCVNIC KERNEL] Expose vendor defined device in ibiou
> 
> Alex,
> 
> Attached patch contains some modifications in qlgcvnic driver for sending different instance IDs
> for each viport communicating with the same EVIC IOC.
> 
> Please let me know of your comments/suggestions.
> 
> Regards
> Deepak