[ofw] [PATCH] mlx4: change prints from error to information

Sean Hefty sean.hefty at intel.com
Mon May 11 14:39:18 PDT 2009


TRACE_LEVEL_ERROR is intended for "Severe errors".  Change ref/deref
interface and DriverEntry exit log messages from error to informational
only.  This avoids displaying misleading "***ERROR***" messages on the
debug terminal.

Signed-off-by: Sean Hefty <sean.hefty at intel.com>
---
I will commit this if I can get an ack on the changes.

diff -up -r -X \mshefty\scm\winof\trunk\docs\dontdiff.txt -I '\$Id:'
trunk\hw/mlx4/kernel/hca/drv.c branches\winverbs\hw/mlx4/kernel/hca/drv.c
--- trunk\hw/mlx4/kernel/hca/drv.c	2009-04-15 16:49:51.359125000 -0700
+++ branches\winverbs\hw/mlx4/kernel/hca/drv.c	2009-05-11 11:20:19.991478400
-0700
@@ -164,7 +164,7 @@ __ref_ifc(
 	cl_atomic_inc( &p_fdo->n_hca_ifc_ref );
 	ObReferenceObject( p_dev_obj );
 
-	HCA_PRINT( TRACE_LEVEL_ERROR, HCA_DBG_PNP, 
+	HCA_PRINT( TRACE_LEVEL_INFORMATION, HCA_DBG_PNP, 
 		("MLX4_HCA: CA_guid %I64x, hca_ifc_ref %d\n",
 		p_fdo->hca.guid, p_fdo->n_hca_ifc_ref) );
 
@@ -182,7 +182,7 @@ __deref_ifc(
 	cl_atomic_dec( &p_fdo->n_hca_ifc_ref );
 	ObDereferenceObject( p_dev_obj );
 
-	HCA_PRINT( TRACE_LEVEL_ERROR, HCA_DBG_PNP, 
+	HCA_PRINT( TRACE_LEVEL_INFORMATION, HCA_DBG_PNP, 
 		("MLX4_HCA: CA_guid %I64x, hca_ifc_ref %d\n",
 		p_fdo->hca.guid, p_fdo->n_hca_ifc_ref) );
 
@@ -591,7 +591,7 @@ Return Value:
 	}
 
 end:
-	HCA_PRINT( TRACE_LEVEL_ERROR ,HCA_DBG_PNP ,
+	HCA_PRINT( TRACE_LEVEL_INFORMATION,HCA_DBG_PNP ,
 		("exit status %#x.\n", status));
 	HCA_EXIT( HCA_DBG_PNP );
 	return status;
diff -up -r -X \mshefty\scm\winof\trunk\docs\dontdiff.txt -I '\$Id:'
trunk\hw/mthca/kernel/hca_pnp.c branches\winverbs\hw/mthca/kernel/hca_pnp.c
--- trunk\hw/mthca/kernel/hca_pnp.c	2009-04-15 16:49:52.093500000 -0700
+++ branches\winverbs\hw/mthca/kernel/hca_pnp.c	2009-05-11 11:21:32.147266600
-0700
@@ -810,7 +810,7 @@ __ref_ifc(
 	cl_atomic_inc( &p_ext->n_hca_ifc_ref );
 	ObReferenceObject( p_dev_obj );
 
-	HCA_PRINT( TRACE_LEVEL_ERROR, HCA_DBG_PNP, 
+	HCA_PRINT( TRACE_LEVEL_INFORMATION, HCA_DBG_PNP, 
 		("MTHCA: CA_guid %I64x, hca_ifc_ref %d\n",
 		p_ext->hca.guid, p_ext->n_hca_ifc_ref) );
 
@@ -828,7 +828,7 @@ __deref_ifc(
 	cl_atomic_dec( &p_ext->n_hca_ifc_ref );
 	ObDereferenceObject( p_dev_obj );
 
-	HCA_PRINT( TRACE_LEVEL_ERROR, HCA_DBG_PNP, 
+	HCA_PRINT( TRACE_LEVEL_INFORMATION, HCA_DBG_PNP, 
 		("MTHCA: CA_guid %I64x, hca_ifc_ref %d\n",
 		p_ext->hca.guid, p_ext->n_hca_ifc_ref) );
 





More information about the ofw mailing list