[ofw] RE: Svn commit 2183

[Smith, Stan]

Hello,
  Did you want fries with that?      :-)

--- Z:/Documents and Settings/scsmith/My Documents/openIB-windows/SVN/gen1/trunk/WinOF/buildrelease.bat Mon May 11 13:36:34 2009
+++ F:/openIB-windows-svn/latest/gen1/trunk/WinOF/BuildRelease.bat      Thu May 14 13:08:10 2009
@@ -178,13 +178,19 @@

 rem Platform SDK path - watchout for missing LoadPerf.h (installsp.c)

-set _PSDK=C:\PROGRA~1\MICROS~3\Windows\v6.1
+if DEFINED PLATFORM_SDK_PATH (
+    set _PSDK=%PLATFORM_SDK_PATH%
+) else (
+    set _PSDK=C:\PROGRA~1\MICROS~3\Windows\v6.1
+)
 if NOT EXIST %_PSDK% (
     echo Missing PLATFORM SDK @ %_PSDK%
     exit /B 1
 )

-set ND_SDK_PATH=C:\PROGRA~1\MICROS~4\NetworkDirect
+if not DEFINED ND_SDK_PATH (
+    set ND_SDK_PATH=C:\PROGRA~1\MICROS~4\NetworkDirect
+)
 if NOT EXIST %ND_SDK_PATH% (
     echo Missing Network Direct SDK @ %ND_SDK_PATH%
     exit /B 1
@@ -411,7 +417,7 @@
 set WDK_PATH=%_DDK%
 set WINOF_PATH=%CD%
 set OPENIB_REV=%SVN%
-set PLATFORM_SDK_PATH=%_PSDK%
+if not DEFINED PLATFORM_SDK_PATH  set PLATFORM_SDK_PATH=%_PSDK%

 rem Compile in a specific folder? compf | allf
 if EXIST "%FPATH%" pushd %FPATH%

Stan.

Fab Tillier wrote:
>> --- C:/Documents and Settings/scsmith/Local
>> Settings/Temp/BuildRelease.bat-revBASE.svn000.tmp.bat       Thu May
>> 14 10:16:43 2009 +++ C:/Documents and Settings/scsmith/My
>> Documents/openIB- windows/SVN/gen1/trunk/WinOF/BuildRelease.bat Mon
>>  May 11 13:36:34 2009 @@ -177,7 +177,18 @@ )
>>
>>  rem Platform SDK path - watchout for missing LoadPerf.h
>> (installsp.c) -set _PSDK=%SystemDrive%\progra~1\mi2578~1
>> +
>> +set _PSDK=C:\PROGRA~1\MICROS~3\Windows\v6.1
>
> Why not add a check to see if the env variable is already set?  This
> would allow people who have things installed in different places to
> set the environment variable and then call the script and get proper
> behavior...
>
> For example, my SDK path is c:\SDK\6.1
>
>> +if NOT EXIST %_PSDK% (
>> +    echo Missing PLATFORM SDK @ %_PSDK%
>> +    exit /B 1
>> +)
>> +
>> +set ND_SDK_PATH=C:\PROGRA~1\MICROS~4\NetworkDirect
>
> Same here.  For me this is d:\dev\hpc\private\networking\src
>
>> +if NOT EXIST %ND_SDK_PATH% (
>> +    echo Missing Network Direct SDK @ %ND_SDK_PATH% +    exit /B 1
>> +)