[ofw] RE: IBBUS - keep last HCA reference until IBAL is shutdown.

[Smith, Stan]

Leonid Keller wrote:
> Please, commit.

Committed as svn.2189 + comment to explain logic.

Thank you,

Stan.

>
>> -----Original Message-----
>> From: Smith, Stan [mailto:stan.smith at intel.com]
>> Sent: Tuesday, May 19, 2009 12:35 AM
>> To: Leonid Keller
>> Cc: ofw at lists.openfabrics.org
>> Subject: IBBUS - keep last HCA reference until IBAL is shutdown.
>>
>> Hello,
>>   Keep the last ibbus HCA IF reference until IBAL is
>> shutdown; al_cleanup() completes. The idea is that IBAL needs
>> the HCA to stick around until it's done cleaning up. Not good
>> to have the last HCA disappear out from underneath.
>> The code is wrong in svn, ic == 1 at this juncture, ic does
>> not go to zero until free_bfi() called later.
>>
>> I will commit upon your approval.
>>
>> Thanks,
>>
>> Stan.
>>
>> Signed off by stan.smith at intel.com
>>
>> diff U3 C:/Documents and Settings/scsmith/Local
>> Settings/Temp/bus_pnp-revBASE.svn002.tmp.c C:/Documents and
>> Settings/scsmith/My
>> Documents/openIB-windows/SVN/gen1/trunk/core/bus/kernel/bus_pnp.c
>> --- C:/Documents and Settings/scsmith/Local
>> Settings/Temp/bus_pnp-revBASE.svn002.tmp.c  Mon May 18 14:22:55 2009
>> +++ C:/Documents and Settings/scsmith/My
>> Documents/openIB-windows/SVN/gen1/trunk/core/bus/kernel/bus_pn
>> p.c      Mon May 18 14:27:00 2009
>> @@ -576,7 +576,7 @@
>>                 p_ext->p_iou_mgr = NULL;
>>         }
>>
>> -       if ( ic > 0 && p_ext->hca_ifc_taken ) {
>> +       if ( ic > 1 && p_ext->hca_ifc_taken ) {
>>                 p_ext->hca_ifc.InterfaceHeader.InterfaceDereference(
>>                         p_ext->hca_ifc.InterfaceHeader.Context);
>>                 p_ext->hca_ifc_taken = FALSE;