[ofw] RE: [PATCH 1/2] contain pthreads defs with ifdef HAVE_LIBPTHREAD

Smith, Stan stan.smith at intel.com
Fri Nov 6 09:07:58 PST 2009


Sasha Khapyorsky wrote:
> On 09:07 Thu 05 Nov     , Smith, Stan wrote:
>>
>> The use of ifdef HAVE_LIBPTHREAD was based on existing
>> HAVE_LIBPTHREAD usage in opensm/include/opensm/osm_stats.h @ line
>> 97.
>
> Right, but it was used due to differences in the functionality between
> cl_event_t and pthread stuff. I would be happy to remove those
> #ifdef's upon such differences elimination.
>
>> If the community prefers the use of macros then these two patches
>> can be skipped.
>
> I think that macros are nicer.
>
> Sasha

OK, will proceed with macros. Skip previously submitted patch set.
I will submit patches to remove relevant HAVE_LIBPTHREAD as not all can/should be removed.



More information about the ofw mailing list