[ofw] Re: [PATCH] osm_subnet.c

Sean Hefty sean.hefty at intel.com
Mon Oct 5 09:20:40 PDT 2009


>>  /**********************************************************************
>>   **********************************************************************/
>> -static long compar_mgids(const void *m1, const void *m2)
>> +static intn_t compar_mgids(const void *m1, const void *m2)
>
>Any disagreement about changing a prototype of this method
>(cl_pfn_fmap_cmp_t) in complib to use standard type (long) instead of
>"homemade" and less clear one ('intn_t')?
>
>Sasha
>
>>  {
>>         return memcmp(m1, m2, sizeof(ib_gid_t));
>>  }

If the function is simply a wrapper around a single call to memcmp, why keep it
at all?




More information about the ofw mailing list