[ofw] [PATCH] opensm - standardize on a single Windows #define

Smith, Stan stan.smith at intel.com
Thu Oct 8 10:16:00 PDT 2009


Hefty, Sean wrote:
>> Code cleanup, standardize on a single Windows #define '__WIN__';
>> WIN32 --> __WIN__. Flip usage of ifndef WIN32 --> ifdef __GNUC__
>
> GNUC indicates a specific compiler, not a platform, which is what the
> check is for.

To the best of my understanding OpenSM is built for Linux/OFED, Solaris and Windows.

What would you suggest, given you did not like the ifndef __WIN__ in terms of readability?



More information about the ofw mailing list