[ofw] [PATCH] opensm - standardize on a single Windows #define

Smith, Stan stan.smith at intel.com
Thu Oct 8 11:12:27 PDT 2009


Hefty, Sean wrote:
>> What would you suggest, given you did not like the ifndef __WIN__ in
>> terms of readability?
>
> I was saying that it is slightly easier for me to read:
>
> #ifdef __WIN__
> // windows stuff
> #else                 // <- not __WIN__
> // other stuff
> #endif
>
> versus
>
> #ifndef __WIN_
> // other stuff
> #else                 // <- not not __WIN__
> // windows stuff
> #endif
>
> I don't have a problem with the use of __WIN__ or
>
> #ifndef __WIN__
> // other stuff
> #endif

There is a fair amount of code hoisting to flip the ifndef __WIN__ --> ifdef __WIN__ for readability reasons.
There are bigger fish to fry at this juncture. Perhaps into the future.






More information about the ofw mailing list