[ofw] Re: [PATCH] osmtest - code cleanup

Sasha Khapyorsky sashak at voltaire.com
Mon Oct 12 14:40:54 PDT 2009


On 11:57 Mon 12 Oct     , Stan C. Smith wrote:
> 
> Remove unused ifdef __WIN__ & redundant include.
> 
> Signed-off-by: stan smith <stan.smith at intel.com>

Applied. Thanks. The question is below.

> 
> diff --git a/opensm/osmtest/osmtest.c b/opensm/osmtest/osmtest.c
> index c6ec955..82a814e 100644
> --- a/opensm/osmtest/osmtest.c
> +++ b/opensm/osmtest/osmtest.c
> @@ -43,19 +43,13 @@
>   *
>   */
>  
> -#ifdef __WIN__
> -#pragma warning(disable : 4996)
> -#endif
> -
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <string.h>
> -#ifdef __WIN__
> -#include <complib/cl_timer.h>
> -#else
> +#ifndef __WIN__
>  #include <strings.h>
> -#include <sys/time.h>
>  #endif

I suppose that windows should have string.h, right? Assuming so could we
remove '#ifndef __WIN__' completely here?

Sasha

> +#include <sys/time.h>
>  #include <complib/cl_debug.h>
>  #include "osmtest.h"
>  
> 



More information about the ofw mailing list