[ofw] [PATCH] add missing items from OFED ib_types.h - required by OpenSM 3.2.2

Fab Tillier ftillier at microsoft.com
Tue Oct 13 17:00:56 PDT 2009


Hi Stan,

Stan C. Smith wrote on Tue, 13 Oct 2009 at 16:52:42:

> 
> Let the discussions begin:
> 
> 1) 'static inline' vs/ AL_INLINE ?

AL_INLINE allows an inline function to be exported by a DLL so that if the compiler doesn't inline the function, there exists still a valid DLL export for it.

Static inline doesn't do the same thing.  I suspect that making these functions all static inline would not significantly affect the size of executables.  Most binaries don't reference them anyhow.

> 2) New ib_port_info_t fields; additional driver mods.
> 3) ?

Is the goal here to merge the opensm ib_types.h so that opensm can simply reference the one in inc/iba?  Or will we continue to have multiple versions of ib_types.h (one private to OpenSM, the other for everyone else?)

Thanks,
-Fab




More information about the ofw mailing list