[ofw] RE: [PATCH] umad - add missing item from latest management tree

Sean Hefty sean.hefty at intel.com
Mon Oct 19 08:20:45 PDT 2009


>> I'm not sure why that define was added to umad.h. I don't see it used
>> anywhere within libibumad itself. It is used by the OpenSM umad vendor
>> layer to size an array to simplify things there. It's used to track
>> the umad registrations in the OpenSM umad vendor layer. 32 is plenty
>> as only a few are used but the number could be changed or the scheme
>> could also be changed to not have such a limit.
>
>I remember now: The number comes from drivers/infiniband/user_mad.c
>where IB_UMAD_MAX_AGENTS = 32 so it's the current Linux limitation on
>this. As you said, Windows could be very different in terms of this.

I was guessing that this was used to define an array.  Given that windows does
not have a limit of 32, the define should be moved to opensm or opensm should do
something different here.

- Sean




More information about the ofw mailing list