[ofw] [Patch] [Core/al] Remove useless ASSERT

Alex Naslednikov xalex at mellanox.co.il
Thu Apr 29 08:08:39 PDT 2010


Leonid,
Please, commit without the #if DBG 

-----Original Message-----
From: Hefty, Sean [mailto:sean.hefty at intel.com] 
Sent: Thursday, April 29, 2010 5:59 PM
To: Alex Naslednikov; ofw at lists.openfabrics.org
Subject: RE: [Patch] [Core/al] Remove useless ASSERT

>Index: D:/windows/MLNX_VPI_trunk/core/al/user/ual_cm_cep.c
>===================================================================
>--- D:/windows/MLNX_VPI_trunk/core/al/user/ual_cm_cep.c (revision 5850)
>+++ D:/windows/MLNX_VPI_trunk/core/al/user/ual_cm_cep.c (revision 5851)
>@@ -382,9 +382,13 @@
>  DWORD  bytes_ret;
>
>  AL_ENTER( AL_DBG_CM );
>+
>+#if DBG
>+ if ( !h_al) {
>+  AL_PRINT(TRACE_LEVEL_ERROR ,AL_DBG_ERROR , ("h_al == NULL, probably 
>+because
>qp creation was failed.\n") );
>+ }
>+#endif
>
>- CL_ASSERT( h_al );
>-

Please just remove the assert and not add #if DBG print to complicate the code.



More information about the ofw mailing list