[ofw] why does mthcau link with ibal?

Sean Hefty sean.hefty at intel.com
Thu Jan 14 17:01:58 PST 2010


>For the user mode part this is probably a mistake.

It *is* needed because of ib_get_err_str in mlnx_ual_osbypass.c:

UVP_PRINT_EXIT(TRACE_LEVEL_ERROR ,UVP_DBG_CQ  ,
	"completes with ERROR status %s\n", ib_get_err_str(status)));

(I had changed the sources file in the wrong svn branch from where I was
building.  Once I went to make and test a real patch, the build failed.)

IMO, since this is just a debug print, it would be better to avoid the
dependency.  The caller of poll_cq can just as easily check the error
code and print a message.

- Sean




More information about the ofw mailing list