[ofw] why does mthcau link with ibal?

[Fab Tillier]

Tzachi Dar wrote on Fri, 15 Jan 2010 at 06:09:39

> Can you convert the function to be static inline? I belive that this
> will reomve the dependency.

It references an array of strings - making that static inline will duplicate the strings.

Just use the numeric value instead of the text.

-Fab

> 
> Thanks
> Tzachi
> 
> -----Original Message-----
> From: Sean Hefty [mailto:sean.hefty at intel.com]
> Sent: Friday, January 15, 2010 3:02 AM
> To: Tzachi Dar; ofw_list
> Subject: RE: [ofw] why does mthcau link with ibal?
> 
>> For the user mode part this is probably a mistake.
> 
> It *is* needed because of ib_get_err_str in mlnx_ual_osbypass.c:
> 
> UVP_PRINT_EXIT(TRACE_LEVEL_ERROR ,UVP_DBG_CQ  ,
> 	"completes with ERROR status %s\n", ib_get_err_str(status)));
> 
> (I had changed the sources file in the wrong svn branch from where I was
> building.  Once I went to make and test a real patch, the build failed.)
> 
> IMO, since this is just a debug print, it would be better to avoid the
> dependency.  The caller of poll_cq can just as easily check the error
> code and print a message.
> 
> - Sean
> 
> _______________________________________________
> ofw mailing list
> ofw at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw