[ofw] error when compiling ofed ulp\libibnetdisc

[Smith, Stan]

Uri Habusha wrote:
> I guess we use same WDK version, 6001.10081. That means same compiler.
>
> In any case can you check-in the fix?

Hold on, until we understand why Sean and I can compile with no problems and you cannot, then it's a band-aid not a fix.

Not good Software Engineering practice.

Keep your patch local to your sandbox to make forward progress; don't commit until you understand the cause.

thanks.


>
> -----Original Message-----
> From: Hefty, Sean [mailto:sean.hefty at intel.com]
> Sent: Monday, July 26, 2010 9:29 PM
> To: Uri Habusha; Smith, Stan; ofw at lists.openfabrics.org
> Cc: Leonid Keller; Tzachi Dar; Irena Kruchkovsky; Alex Naslednikov;
> Sasha Khapyorsky; Ira Weiny; linux-rdma at vger.kernel.org
> Subject: RE: error when compiling ofed ulp\libibnetdisc
>
>> The fix is okay. However I wonder how you don't get the error in
>> your environment and we got it. Any idea?
>
> The cast is from an 8-bit value to 64-bit, then back to 16-bit, so
> there's no chance of losing data with the cast.  Maybe the compiler
> got smarter?