[ofw] [PATCH] ibal: set timeout and retry values for RMPP messages

Fab Tillier ftillier at microsoft.com
Fri Jun 18 11:12:40 PDT 2010


Looks good to me.  Did you intend the "From:" to be "Signed-off-by:"?

-Fab

-----Original Message-----
From: ofw-bounces at lists.openfabrics.org [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Hefty, Sean
Sent: Friday, June 18, 2010 11:10 AM
To: ofw_list
Subject: [ofw] [PATCH] ibal: set timeout and retry values for RMPP messages

Define default timeout and retry values for RMPP response messages
if none are provided by the user.  Also mark GETTABLE requests as
needing RMPP.

From: Sean Hefty <sean.hefty at intel.com>
---
diff --git a/trunk/core/al/al_mad.c b/trunk/core/al/al_mad.c
index 4576fa8..51310f9 100644
--- a/trunk/core/al/al_mad.c
+++ b/trunk/core/al/al_mad.c
@@ -61,6 +61,7 @@
 
 #define AL_RMPP_WINDOW			16				/* Max size of RMPP window */
 #define AL_REASSEMBLY_TIMEOUT	5000			/* 5 seconds */
+#define AL_RMPP_RETRIES			5
 
 static void
 __cleanup_mad_disp(
@@ -1452,6 +1453,12 @@ __init_send_mad(
 			return IB_INVALID_SETTING;
 		}
 
+		if( !p_mad_element->timeout_ms )
+			p_mad_element->timeout_ms = AL_REASSEMBLY_TIMEOUT;
+
+		if( !h_send->retry_cnt )
+			h_send->retry_cnt = AL_RMPP_RETRIES;
+
 		p_rmpp_hdr->rmpp_version = rmpp_version;
 		p_rmpp_hdr->rmpp_type = IB_RMPP_TYPE_DATA;
 		ib_rmpp_set_resp_time( p_rmpp_hdr, IB_RMPP_NO_RESP_TIME );
@@ -1570,6 +1577,7 @@ __does_send_req_rmpp(
 		{
 			switch( p_mad_element->p_mad_buf->method )
 			{
+			case IB_MAD_METHOD_GETTABLE:
 			case IB_MAD_METHOD_GETTABLE_RESP:
 			case IB_MAD_METHOD_GETMULTI:
 			case IB_MAD_METHOD_GETMULTI_RESP:

_______________________________________________
ofw mailing list
ofw at lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw




More information about the ofw mailing list