[ofw] [PATCH v2] complib/user: fix timer race conditions

Fab Tillier ftillier at microsoft.com
Mon Jun 28 15:19:22 PDT 2010


Hi Sean,

This looks good to me.  Does it work as intended?  Or is that something for Stan to try at scale?

Hefty, Sean wrote on Mon, 28 Jun 2010 at 14:50:52
> 
> Moved the calculation of the timeout time to inside the critical
> section to improve its accuracy in case an attempt to acquire the
> critical section blocks.

How does this improve accuracy?  I suppose it depend on whether the timeout time is relative to the client making the call, or the call returning.  Having the timeout calculated before the critsec improves the former, calculating it under lock improves the latter.

-Fab 




More information about the ofw mailing list