[ofw] [Patch][Core] Fix possible BSOD during shutdown

Sean Hefty sean.hefty at intel.com
Mon May 3 08:44:08 PDT 2010


>  CL_ASSERT( mad_svc_context );
>  CL_ASSERT( p_mad_response );
>- CL_ASSERT( p_mad_response->send_context1 );
>+
>+
>+ if ( !p_mad_response->send_context1 ) {
>+  CL_ASSERT( p_mad_response->send_context1 );
>+  ib_put_mad( p_mad_response );
>+  AL_EXIT( AL_DBG_SMI );
>+  return;
>+ }

This looks like it's fixing a symptom, not the bug.  Either send_context1 is
allowed to be NULL, or it should be set.  If it's allowed to be NULL, then
remove the ASSERT.  If it should be set, then keep the ASSERT and fix the code
that leads to it being hit.




More information about the ofw mailing list