[ofw] ib_portinfo_record_t padding history?

[Hal Rosenstock]

Hi Stan,

On Wed, May 19, 2010 at 11:47 AM, Smith, Stan <stan.smith at intel.com> wrote:
> Hal Rosenstock wrote:
>> On Tue, May 18, 2010 at 2:50 PM, Smith, Stan <stan.smith at intel.com>
>> wrote:
>>>
>>> Hello,
>>>  Does anyone know the history as to why the OFED for Windows 'struct
>>> _ib_portinfo_record' has 6 bytes of padding while the OFED for Linux
>>> version does not?
>>>
>>> With padding sizeof ib_portinfo_record_t == 70, without padding
>>> sizeof ib_portinfo_record_t == 64.
>>>
>>> I'd like to remove the padding to be compatible, along with the fact
>>> 'osmtest -f c' produces a correct fabric inventory file.
>>>
>>> Thoughts?
>>
>> In Linux, the 6 bytes of padding were removed in PortInfoRecord
>> shortly after MaxCreditHint and LinkRtLatency added to PortInfo. Do
>> the latter appear in the Windows version for PortInfo ?
>>
>> -- Hal
>
> Hi Hal,
>  Windows is currently using opensm 3.3.3, this discussion pertains to 3.3.5.
> MaxCreditHint and LinkRtLatency are not in the 3.3.5 ib_types.h, although the 6 bytes from PortInfo record are removed in 3.3.5 ib_types.h?

If those 6 bytes are not in PortInfo, then there need to be the 6
bytes of additional pad in the PortInfoRecord. Is that the case for
3.3.3 ?

-- Hal

>
> stan.
>
>>
>>>
>>> thanks.
>>>
>>> #include <complib/cl_packon.h>
>>> typedef struct _ib_portinfo_record
>>> {
>>>        ib_net16_t              lid;
>>>        uint8_t         port_num;
>>>        uint8_t         resv;
>>>        ib_port_info_t  port_info;
>>>        uint8_t         pad[6];         <-- ??
>>>
>>> }       PACK_SUFFIX ib_portinfo_record_t;
>>> #include <complib/cl_packoff.h>
>>> _______________________________________________
>>> ofw mailing list
>>> ofw at lists.openfabrics.org
>>> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
>
>