[ofw] [PATCH] ib_types.h fix comments and whitespace.

Smith, Stan stan.smith at intel.com
Thu May 20 12:43:32 PDT 2010


committed.

Revision: 2797
Author: stansmith
Date: 10:44:35 AM, Thursday, May 20, 2010
Message:
[INC] Fix/add comments plus whitespace: alignment and trailing whitespace removal for easier comparison
with Linux version.

No functionality change!

signed-off-by: stan smith <stan.smith at intel.com>
----
Modified : /gen1/trunk/inc/iba/ib_types.h



Smith, Stan wrote:
> Fix/add comments plus whitespace: alignment and trailing whitespace
> removal for easier comparison with Linux version.
>
> No functionality change!
>
> signed-off-by: stan smith <stan.smith at intel.com>
>
> --- a/inc/iba/ib_types.h      Tue May 18 13:44:15 2010
> +++ b/inc/iba/ib_types.h      Tue May 18 13:43:51 2010
> @@ -904,7 +904,7 @@
>  *
>  * SOURCE
>  */
> -#define IB_MAD_STATUS_BUSY                                   (CL_HTON16(0x0001))
> +#define IB_MAD_STATUS_BUSY                           (CL_HTON16(0x0001))
>  /**********/
>
>  /****d* IBA Base: Constants/IB_MAD_STATUS_REDIRECT
> @@ -2470,8 +2470,8 @@
>  #include <complib/cl_packoff.h>
>  /*
>  * FIELDS
> -*    resv0
> -*            Reserved bytes.
> +*    service_id
> +*            Service ID for QoS.
>  *
>  *    dgid
>  *            GID of destination port.
> @@ -2499,11 +2499,8 @@
>  *    pkey
>  *            Partition key (P_Key) to use on this path.
>  *
> -*    resv1
> -*            Reserved byte.
> -*
> -*    sl
> -*            Service level to use on this path.
> +*    qos_class_sl
> +*            QoS class and service level to use on this path.
>  *
>  *    mtu
>  *            MTU and MTU selector fields to use on this path
> @@ -2858,6 +2855,9 @@
>  *    pkey
>  *            [in] Partition key (P_Key) to use on this path.
>  *
> +*    qos_class
> +*            [in] QoS class to use on this path.  Lower 12-bits are valid.
> +*
>  *    sl
>  *            [in] Service level to use on this path.  Lower 4-bits are valid.
>  *
> @@ -3420,8 +3420,9 @@
>  *    cap_mask
>  *            Supported capabilities of this management class.
>  *
> -*    resp_time_value
> -*            Maximum expected response time.
> +*    cap_mask2_resp_time
> +*            Maximum expected response time and additional
> +*            supported capabilities of this management class.
>  *
>  *    redr_gid
>  *            GID to use for redirection, or zero
> @@ -3890,7 +3891,8 @@
>  *    ib_mad_is_response
>  *
>  * DESCRIPTION
> -*    Returns TRUE if the MAD is a response ('R' bit set),
> +*    Returns TRUE if the MAD is a response ('R' bit set)
> +*    or if the MAD is a TRAP REPRESS,
>  *    FALSE otherwise.
>  *
>  * SYNOPSIS
> @@ -4208,7 +4210,7 @@
>  *
>  * TODO
>  *    This is too big for inlining, but leave it here for now
> -*    since there is not yet another convient spot.
> +*    since there is not yet another convenient spot.
>  *
>  * SYNOPSIS
>  */
> @@ -4429,7 +4431,7 @@
>  }
>  /*
>  * PARAMETERS
> -*    p_smp
> +*    p_sa_mad
>  *            [in] Pointer to the SA MAD packet.
>  *
>  * RETURN VALUES
> @@ -4586,24 +4588,24 @@
>
>  #define IB_PORT_STATE_MASK                                                   0x0F
>  #define IB_PORT_LMC_MASK                                                     0x07
> -#define IB_PORT_LMC_MAX                              0x07
> +#define IB_PORT_LMC_MAX                                                              0x07
>  #define IB_PORT_MPB_MASK                                                     0xC0
>  #define IB_PORT_MPB_SHIFT                                                    6
>  #define IB_PORT_LINK_SPEED_SHIFT                                     4
>  #define IB_PORT_LINK_SPEED_SUPPORTED_MASK                    0xF0
>  #define IB_PORT_LINK_SPEED_ACTIVE_MASK                               0xF0
>  #define IB_PORT_LINK_SPEED_ENABLED_MASK                              0x0F
> -#define IB_PORT_PHYS_STATE_MASK                      0xF0
> -#define IB_PORT_PHYS_STATE_SHIFT             4
> -#define IB_PORT_PHYS_STATE_NO_CHANGE            0
> -#define IB_PORT_PHYS_STATE_SLEEP                1
> -#define IB_PORT_PHYS_STATE_POLLING              2
> -#define IB_PORT_PHYS_STATE_DISABLED             3
> -#define IB_PORT_PHYS_STATE_PORTCONFTRAIN        4
> -#define IB_PORT_PHYS_STATE_LINKUP               5
> -#define IB_PORT_PHYS_STATE_LINKERRRECOVER       6
> -#define IB_PORT_PHYS_STATE_PHYTEST              7
> -#define IB_PORT_LNKDWNDFTSTATE_MASK          0x0F
> +#define IB_PORT_PHYS_STATE_MASK                                              0xF0
> +#define IB_PORT_PHYS_STATE_SHIFT                                     4
> +#define IB_PORT_PHYS_STATE_NO_CHANGE                0
> +#define IB_PORT_PHYS_STATE_SLEEP                    1
> +#define IB_PORT_PHYS_STATE_POLLING                  2
> +#define IB_PORT_PHYS_STATE_DISABLED                 3
> +#define IB_PORT_PHYS_STATE_PORTCONFTRAIN            4
> +#define IB_PORT_PHYS_STATE_LINKUP                   5
> +#define IB_PORT_PHYS_STATE_LINKERRRECOVER           6
> +#define IB_PORT_PHYS_STATE_PHYTEST                  7
> +#define IB_PORT_LNKDWNDFTSTATE_MASK                                  0x0F
>
>  #define IB_PORT_CAP_RESV0                    (CL_NTOH32(0x00000001))
>  #define IB_PORT_CAP_IS_SM                    (CL_NTOH32(0x00000002))
> @@ -5661,7 +5663,7 @@
>  *    ib_port_info_set_hoq_lifetime
>  *
>  * DESCRIPTION
> -*    Sets the Head of Queue Lifetime for which a packet can live in the
> head +*       Sets the Head of Queue Lifetime for which a packet can live
> in the head
>  *  of VL queue
>  *
>  * SYNOPSIS
> @@ -5695,7 +5697,7 @@
>  *    ib_port_info_get_hoq_lifetime
>  *
>  * DESCRIPTION
> -*    Gets the Head of Queue Lifetime for which a packet can live in the
> head +*       Gets the Head of Queue Lifetime for which a packet can live
> in the head
>  *  of VL queue
>  *
>  * SYNOPSIS
> @@ -5743,7 +5745,7 @@
>  *    p_pi
>  *            [in] Pointer to a PortInfo attribute.
>  *
> -*    vl_stall_count
> +*    vl_stall_count
>  *            [in] value to set
>  *
>  * RETURN VALUES
> @@ -5759,7 +5761,7 @@
>  *    ib_port_info_get_vl_stall_count
>  *
>  * DESCRIPTION
> -*    Gets the VL Stall Count which define the number of contiguous
> +*    Gets the VL Stall Count which define the number of contiguous
>  *  HLL (hoq) drops that will put the VL into stalled mode
>  *
>  * SYNOPSIS
> @@ -6046,10 +6048,10 @@
>  *            [in] Pointer to a PortInfo attribute.
>  *
>  *    phy_threshold
> -*            [in] Physical Link Errors Threshold above which Trap 129 is
> generated +*          [in] Physical Link Errors Threshold above which Trap
>  129 is generated *
>  *  overrun_threshold
> -*     [in] Credits overrun Errors Threshold above which Trap 129 is
> generated +*     [in] Credits overrun Errors Threshold above which
>  Trap 129 is generated *
>  * RETURN VALUES
>  *    None.
> @@ -6242,11 +6244,11 @@
>  }
>  /*
>  * PARAMETERS
> -*    p_ni
> -*            [in] Pointer to a PortInfo attribute.
> +*    p_si
> +*            [in] Pointer to a SwitchInfo attribute.
>  *
>  * RETURN VALUES
> -*    Returns the LMC value assigned to this port.
> +*    None
>  *
>  * NOTES
>  *
> @@ -6351,8 +6353,8 @@
>  *       pkey
>  *               Partition key (P_Key) to use on this path.
>  *
> -*       sl
> -*               Service level to use on this path.
> +*       qos_class_sl
> +*               QoS class and service level to use on this path.
>  *
>  *       mtu
>  *               MTU and MTU selector fields to use on this path
> @@ -6362,6 +6364,12 @@
>  *       pkt_life
>  *               Packet lifetime
>  *
> +*    service_id_8msb
> +*            8 most significant bits of Service ID
> +*
> +*    service_id_56lsb
> +*            56 least significant bits of Service ID
> +*
>  *       preference
>  *               Indicates the relative merit of this path versus
> other path
>  *               records returned from the SA.  Lower numbers are
> better. @@ -6446,7 +6454,7 @@
>  ib_multipath_rec_sl(
>       IN      const   ib_multipath_rec_t* const       p_rec )
>  {
> -     return ((uint8_t) ((cl_ntoh16(p_rec->qos_class_sl)) &
> IB_MULTIPATH_REC_SL_MASK)); + return ((uint8_t)
>  ((cl_ntoh16(p_rec->qos_class_sl)) & IB_MULTIPATH_REC_SL_MASK)); }
>  /*
>  * PARAMETERS
> @@ -7206,9 +7214,6 @@
>  *
>  *    port_gid
>  *            Valid GID of the endpoint joining this multicast group.
> -*
> -*    requestor_gid
> -*            GID of the endpoint making this request on hehave of port_gid.
>  *
>  *    qkey
>  *            Q_Key to be used by this multicast group.




More information about the ofw mailing list