[ofw] [PATCH] remove call to generate port, pass in port arg

Smith, Stan stan.smith at intel.com
Thu Nov 11 08:18:24 PST 2010


Hefty, Sean wrote:
>>   In the function ipoib_endpt_queue(), pass in the p_port arg
>> instead of calling a function to generate the p_port arg.
>
> I don't see where anything is removed.  Is there a missing piece to
> this patch?
>
> - Sean

Appears I entered ipoib_endpoint.h twice as text, oops - late in the day.
Although in the included files, ipoib_endpoint.cpp is present.

>
>>
>> signed-off-by: stan smith <stan.smith at intel.com>
>>
>> --- A/ulp/ipoib_NDIS6_CM/kernel/ipoib_endpoint.h        Wed Nov 10
>> 17:06:11 2010 +++ B/ulp/ipoib_NDIS6_CM/kernel/ipoib_endpoint.h
>> Wed Nov 10 17:02:46 2010 @@ -223,7 +223,8 @@
>>
>>  NDIS_STATUS
>>  ipoib_endpt_queue(
>> -       IN              ipoib_endpt_t* const
>> p_endpt );
>> +       IN              ipoib_port_t* const
>> p_port,
>> +       IN              ipoib_endpt_t* const
>> p_endpt );
>>
>>  struct _ipoib_port *
>>  ipoib_endpt_parent(
>>
>> --- A/ulp/ipoib_NDIS6_CM/kernel/ipoib_endpoint.h        Wed Nov 10
>> 17:06:11 2010 +++ B/ulp/ipoib_NDIS6_CM/kernel/ipoib_endpoint.h
>> Wed Nov 10 17:02:46 2010 @@ -223,7 +223,8 @@
>>
>>  NDIS_STATUS
>>  ipoib_endpt_queue(
>> -       IN              ipoib_endpt_t* const
>> p_endpt );
>> +       IN              ipoib_port_t* const
>> p_port,
>> +       IN              ipoib_endpt_t* const
>> p_endpt );
>>
>>  struct _ipoib_port *
>>  ipoib_endpt_parent(
>>
>> --- A/ipoib_NDIS6_CM/kernel/ipoib_port.cpp      Wed Nov 10 17:05:24
>> 2010 +++ B/ipoib_NDIS6_CM/kernel/ipoib_port.cpp      Wed Nov 10
>>         17:05:07 2010 @@ -6732,7 +6732,7 @@ cl_obj_unlock(
>> &p_port->obj );
>>
>>         cl_perf_start( EndptQueue );
>> -       status = ipoib_endpt_queue( *pp_endpt );
>> +       status = ipoib_endpt_queue( p_port, *pp_endpt );
>>         cl_perf_stop( &p_port->p_adapter->perf, EndptQueue );
>>         if( status != NDIS_STATUS_SUCCESS )
>>                 *pp_endpt = NULL;




More information about the ofw mailing list