[ofw] [PATCH] removed unused variable

[Alex Naslednikov]

Hello Stan,
This variable was used at CM flow. 
I kept just to allow smooth inculcating of CM flow back to the trunk.
But you are absolutely right that it should be either totally removed or totally commented.
Please, remove it if you don't need it anymore for CM flow.

-----Original Message-----
From: Smith, Stan [mailto:stan.smith at intel.com] 
Sent: Tuesday, November 16, 2010 7:05 PM
To: Smith, Stan; Alex Naslednikov
Cc: ofw at lists.openfabrics.org
Subject: RE: [PATCH] removed unused variable

Hello,
  Do you have any issues with this patch?
Original email sent 11/9/10.

thanks,

stan.

Smith, Stan wrote:
> Hello Alex,
>   What would you like to do with the h_buffer_pool variable in struct
> ipoib_buf_mgr_t? Is h_buffer_pool a left over NDIS5 item or future
> work?
> h_buffer_pool is only initialized, never allocated, with the free
> commented out?
>
> I would vote to remove for now.
>
> signed-off-by: stan smith <stan.smith at intel.com>
>
> stan.
>
> --- A/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.h  Tue Nov 09 10:45:50 2010
> +++ B/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.h  Tue Nov 09 10:45:13 2010
> @@ -307,7 +307,6 @@
>       cl_qpool_t                      recv_pool;
>
>       NDIS_HANDLE                     h_packet_pool;
> -     NDIS_HANDLE                     h_buffer_pool;
>
>       NPAGED_LOOKASIDE_LIST   send_buf_list;
>       NDIS_HANDLE                     h_send_pkt_pool;
> @@ -321,9 +320,6 @@
>  *
>  *    h_packet_pool
>  *            NDIS packet pool, used to indicate receives to NDIS.
> -*
> -*    h_buffer_pool
> -*            NDIS buffer pool, used to indicate receives to NDIS.
>  *
>  *    send_buf_list
>  *            Lookaside list for dynamically allocating send buffers for send
>
> --- A/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp        Tue Nov 09 10:46:17
> 2010 +++ B/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp   Tue Nov 09
> 10:45:39 2010 @@ -1396,7 +1396,6 @@
>       cl_qpool_construct( &p_port->buf_mgr.recv_pool );
>
>       p_port->buf_mgr.h_packet_pool = NULL;
> -     p_port->buf_mgr.h_buffer_pool = NULL;
>
>       NdisInitializeNPagedLookasideList( &p_port->buf_mgr.send_buf_list,
>               NULL, NULL, 0, MAX_LSO_PAYLOAD_MTU, 'bipi', 0 );
> @@ -1503,9 +1502,7 @@
>       if( p_port->buf_mgr.h_send_pkt_pool )
>               NdisFreeNetBufferListPool ( p_port->buf_mgr.h_send_pkt_pool );
>
> -     /* Destroy the receive packet and buffer pools.
> -     if( p_port->buf_mgr.h_buffer_pool )
> -             NdisFreeBufferPool( p_port->buf_mgr.h_buffer_pool );*/
> +     /* Destroy the receive packet and buffer pools. */
>       if( p_port->buf_mgr.h_packet_pool )
>               NdisFreeNetBufferListPool ( p_port->buf_mgr.h_packet_pool );