[ofw] [PATCH] prevent compiler warning

Smith, Stan stan.smith at intel.com
Fri Oct 29 16:20:08 PDT 2010


When including comp_lib.h, which includes, cl_log.h and per chance you do not reference __build_str() the compiler will 'warn' about unreferened static function __build_str().
The warning may cause a compilation to fail.
Removing cl_log.h form comp_lib.h impacts 14 other files; the path of least resistance is to tag __build_str() as inline such that if not referenced is it not compiled; hence no unreferenced function.

signed-off-by: stan smith <stan.smith at intel.com>

--- A/inc/complib/cl_log.h      Fri Oct 29 15:24:30 2010
+++ B/inc/complib/cl_log.h      Fri Oct 22 11:00:17 2010
@@ -214,7 +214,7 @@
 extern WCHAR g_cl_wlog[ CL_LOG_BUF_LEN ];
 extern UCHAR g_cl_slog[ CL_LOG_BUF_LEN ];

-static void __build_str( const char *  format, ... )
+static inline void __build_str( const char *   format, ... )
 {
        NTSTATUS status;
        va_list p_arg;




More information about the ofw mailing list