Applied on 2887.
Thanks
Tzachi
From: Leonid Keller
Sent: Wednesday, September 01, 2010 12:54 PM
To: Fab Tillier; Tzachi Dar; ofw at lists.openfabrics.org
Subject: RE: patch: [IBAL] remove unnecessary ASSERT
We hit it in our test program, which - in error flow - creates PD with all possible pd_types.
The test expects to get IB_INVALID_PARAMETER, which it gets.
We believe, that the error status that is returned in this case is enough to spot an error.
From: ofw-bounces at lists.openfabrics.org [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Fab Tillier
Sent: Tuesday, August 31, 2010 7:56 PM
To: Tzachi Dar; ofw at lists.openfabrics.org
Subject: Re: [ofw] patch: [IBAL] remove unnecessary ASSERT
The assert here is to trap a bad call to alloc_pd. Why is it being removed? Did you have code that hit it? Did you fix that code so it wouldn't hit the assertion? Or was the assertion incorrect? Basically, the assert has been in the code for years now - what suddenly makes it unnecessary?
-Fab
From: ofw-bounces at lists.openfabrics.org [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Tzachi Dar
Sent: Tuesday, August 31, 2010 8:29 AM
To: ofw at lists.openfabrics.org
Subject: [ofw] patch: [IBAL] remove unnecessary ASSERT
Signed off by: Leonid
Mlnx 5599
Index: B:/users/tzachid/projinf9/trunk/core/al/al_pd.c
===================================================================
--- B:/users/tzachid/projinf9/trunk/core/al/al_pd.c (revision 5598)
+++ B:/users/tzachid/projinf9/trunk/core/al/al_pd.c (revision 5599)
@@ -137,7 +137,6 @@
break;
default:
- CL_ASSERT( h_pd->type == IB_PDT_ALIAS || h_pd->type == IB_PDT_NORMAL );
status = IB_INVALID_PARAMETER;
}
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20100902/45492487/attachment.html>