[ofw] FW: [patch] Updated ibv_XXXX_bw/ ibv_XXXX_lat tools - ibv_read_bw, ibv_read_lat

[Irena Gannon]

Applied in 2918

Thank you,
Irena

-----Original Message-----
From: Hefty, Sean [mailto:sean.hefty at intel.com] 
Sent: Wednesday, September 01, 2010 8:21 PM
To: Irena Kruchkovsky; ofw at lists.openfabrics.org
Subject: RE: [ofw] FW: [patch] Updated ibv_XXXX_bw/ ibv_XXXX_lat tools - ibv_read_bw, ibv_read_lat

Can we patch the Linux code first, so that there are no differences?

For example, typecasts can be added to the Linux code.   And:

> < #if HAVE_CONFIG_H
> 
> < #  include <config.h>
> 
> < #endif /* HAVE_CONFIG_H */

we can add a config.h file to windows that adds:

> > #include <windows.h>
> 
> >
> 
> > #include <ws2tcpip.h>
> 
> > #include <winsock2.h>

so that those include files remain removed from the Linux code.  Any other Linux headers included by the tools can be abstracted using the inc/user/linux header files, adding any files that may be missing.

> > #include "..\..\etc\user\getopt.c"

This can be handled by a separate source file added as part of the build.  See tools/infiniband-diags/src/ibdiag_windows.c for an example.

It would just be great if the perftests could be pulled directly from the Linux source tree and dropped in as is.

In any case, my main objection to the patches (duplicating getopt) was fixed.  So, I'm okay with these.

- Sean