[ofw] [Patch][IPoIB_NDIS6_CM] Handling memory access violation at destroy when __port_init fails.

[Smith, Stan]

________________________________
From: Alex Naslednikov [mailto:xalex at mellanox.co.il]
Sent: Tuesday, September 21, 2010 8:59 AM
To: Smith, Stan; ofw at lists.openfabrics.org
Subject: RE: [ofw] [Patch][IPoIB_NDIS6_CM] Handling memory access violation at destroy when __port_init fails.

You are right !
May I add it and then commit ?

Please do so.

stan.

From: Smith, Stan [mailto:stan.smith at intel.com]
Sent: Tuesday, September 21, 2010 5:57 PM
To: Alex Naslednikov; ofw at lists.openfabrics.org
Subject: RE: [ofw] [Patch][IPoIB_NDIS6_CM] Handling memory access violation at destroy when __port_init fails.

Please see below.

________________________________
From: ofw-bounces at lists.openfabrics.org [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Alex Naslednikov
Sent: Tuesday, September 21, 2010 7:54 AM
To: ofw at lists.openfabrics.org
Subject: [ofw] [Patch][IPoIB_NDIS6_CM] Handling memory access violation at destroy when __port_init fails.
Index: B:/users/xalex/WoF-trunk/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp
===================================================================
--- B:/users/xalex/WoF-trunk/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp        (revision 2939)
+++ B:/users/xalex/WoF-trunk/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp     (working copy)
@@ -3428,6 +3428,7 @@
                cl_qpool_destroy(&p_port->send_mgr.sg_pool);

                //Now, free port descriptor
+             if (p_port->p_desc)
                ExFreePoolWithTag(p_port->p_desc, 'XMXA');

Is the following statement also required?
                p_port->p_desc = NULL;

                //Lookaside list will be destroyed in __buf_mgr_destroy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20100921/2863c77a/attachment.html>