[ofw] [PATCH] stop leaking spin lock

Alex Naslednikov xalex at mellanox.co.il
Wed Sep 22 02:43:31 PDT 2010


This patch was applied at 2946.
Please, note that there are still no functionality changes, because this code is still inactive (CM flow)
However, when CM flow will be active this change is essential because of setting this spinlock at calling thread.



-----Original Message-----
From: Smith, Stan [mailto:stan.smith at intel.com] 
Sent: Wednesday, September 22, 2010 2:12 AM
To: Alex Naslednikov
Cc: ofw at lists.openfabrics.org
Subject: [PATCH] stop leaking spin lock


Missing spin lock free call for remove_lock.

signed-off-by: stan smith <stan.smith at intel.com>

--- a/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp  Tue Sep 21 17:03:57 2010
+++ b/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp  Tue Sep 21 17:03:19 2010
@@ -6131,8 +6131,9 @@
                        cl_obj_destroy( &p_endpt->obj );
                }
        }
-
        p_port->endpt_mgr.thread_is_done++;
+
+       NdisFreeSpinLock( &p_port->endpt_mgr.remove_lock );
        NdisFreeSpinLock( &p_port->endpt_mgr.conn_lock );

        IPOIB_PRINT_EXIT( TRACE_LEVEL_INFORMATION, IPOIB_DBG_INIT,



More information about the ofw mailing list