[ofw] [PATCH] Update libibmad and infiniband-diags

Hefty, Sean sean.hefty at intel.com
Mon Aug 8 14:30:23 PDT 2011


> Do the git commits imply SVN commits?

No - the git commits being referenced are the upstream commits to Ira's and Hal's git trees.  I'm simply updating svn, which I have not committed yet.

> Since you are likely one of the 'few' who use git for windows projects, it is
> not a burden on the rest of the Windows IB project members to force everyone
> else to refer to the git trees for changes and/or an explanation of the bigger
> picture of what/how things have changed?

All changes were posted to the linux-rdma mail list and are also visible by using the ofa git web server for anyone who doesn't have git.  Really, anyone interested in changes to opensm, ibmad, and ib-diags should follow the upstream changes and not the svn mirror of those changes.  A full list of changes to the ib-diags is given below though.
 
> Does opensm still build?

yes - the changes to ib_types.h updated a reserved field in portinfo_record to an options field.  A print statement in osm_helper.c needed to be updated.
 
> We 'really' need to separate out from ib_types.h the diags/MAD/opensm issues
> into separate header files...the kitchen sink is rather larger and continues
> to grow. :-(

One issue is that the IB spec continues to be updated.  The Linux stack ends up with those updates reflected in their ib_types header file much sooner than the windows stack does.  Note that these changes do not end up affecting runtime, just compiling.  But there's very little one can do except update all programs that access a reserved field once it's been un-reserved by the IBTA.


ib-diag changes:

commit a817e38e5275dcf75404af19b8592c03f4822118
Author: shefty <sean.hefty at intel.com>
Date:   Fri Aug 5 20:44:39 2011 +0000

    ibnetdisc: Fix build for windows
    
    Fix a couple of compile errors that occur building on windows.
    
    Signed-off-by: Sean Hefty <sean.hefty at intel.com>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 65818eabe526aee176fc7129e2b5c1b264ba0a3b
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Fri Aug 5 16:59:08 2011 -0700

    infiniband-diags: make library dependancies explicit

commit 6f87728b6f0e230a8706842695a8388a9083b508
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Wed Aug 3 13:09:00 2011 -0700

    infiniband-diags: update check for latest dump function in libibmad
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit bb7bcdb9515bdbaa6eb79e6189172fad5b8b52ef
Merge: d85a6a8 2cd8062
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Wed Aug 3 12:47:20 2011 -0700

    Merge branch 'master' of git://git.openfabrics.org/~iraweiny/infiniband-diags

commit d85a6a88f35bae0182c116298ef57cc224bb02dd
Author: Hal Rosenstock <hal at dev.mellanox.co.il>
Date:   Sat Jul 23 11:02:52 2011 +0000

    infiniband-diags/smpquery: Add Mellanox extended portinfo query
    
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit c80dc802054484883a92f96fc9ede9f2a9c076df
Author: Hal Rosenstock <hal at dev.mellanox.co.il>
Date:   Wed Aug 3 17:58:04 2011 +0000

    infiniband-diags/libibnetdisc/ibnetdisc.c: Remove compile warning
    
    src/ibnetdisc.c: In function 'ibnd_find_port_dr':
    src/ibnetdisc.c:676: warning: 'rc' may be used uninitialized in this function
    
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit aa80e79a008717bc40145e06a7f693ae5c592179
Author: Albert L.Chu <chu11 at llnl.gov>
Date:   Thu Jul 14 17:10:52 2011 -0700

    perfquery: support many optional performance counters, including congestion control counters
    
    Signed-off-by: Albert L. Chu <chu11 at llnl.gov>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 2cd806239506c5d6a153a61af4865aeba6cce243
Merge: ae82553 fe649a5
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Wed Aug 3 10:34:06 2011 -0700

    Merge branch 'master' of git://git.openfabrics.org/~iraweiny/infiniband-diags

commit ae82553337eaab6140582ef782cbd11e32cb1401
Author: Hal Rosenstock <hal at dev.mellanox.co.il>
Date:   Tue Jul 26 12:18:02 2011 +0000

    infiniband-diags/saquery.c: PortInfoRecord now has an options field
    
    rather than reserved field
    
    This is for coordination with the latest ib_types.h
    
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>

commit a9c5a76a271c9b4b3ee33a835c7305673f377c8c
Merge: 0ee2db5 1274813
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Wed Aug 3 09:33:16 2011 -0700

    Merge branch 'conv-iblinkinfo-portguid'

commit fe649a53938d9f247f590faac39e32a212e74165
Author: Albert L.Chu <chu11 at llnl.gov>
Date:   Thu Jul 14 17:10:52 2011 -0700

    perfquery: support many optional performance counters, including congestion control counters
    
    Signed-off-by: Albert L. Chu <chu11 at llnl.gov>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 0ee2db536f7e04678664ac51c0f940fa76cbac1c
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Wed Jul 20 10:01:26 2011 -0700

    infiniband-diags: ibqueryerrors fix null threshold_str
    
    When printing "(null)" was being printed if there was no threshold file
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 1274813595ceaf4c6cc0726e0aa157111ce4ce19
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Thu Jul 14 14:27:07 2011 -0700

    infiniband-diags: convert ib[linkinfo|queryerrors] to use PortGUIDs
    
    NodeGUID's are no longer output nor accepted as input.
    
    Furthermore expand search to cover all node types:
    
    iblinkinfo CA and router nodes are output in a slightly different manner due to
    each port containing a unique PortGUID.  "-l" output is unaffected.
    
    ibqueryerrors correctly reports PortGUID for each port printed.
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit ac291237eec71b758401bab4b8d9ec51b6387e79
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Thu Jul 14 16:05:30 2011 -0700

    infiniband-diags: libibnetdisc Allow a DR Path partial fabric query starting at a CA
    
    The old algorithm would attempt to extend a DR path through the CA and fail.
    The new algorithm retracts the path properly.
    
    This does not work when combined routing is used with the CA as a starting
    point.  :-(
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit f3e0901c7dd69f5d5b81f80a9d1c675898569f6b
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Thu Jul 14 14:25:41 2011 -0700

    infiniband-diags: libibnetdisc add port interface
    
    Add ability to find port's based on PortGUID and DRPath
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 89b6a7b026e85e6ddfa8d47dde951f7accd5fff3
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Thu Jun 9 22:18:28 2011 -0700

    infiniband-diags: move core saquery functionality to ibdiag_common
    
    While this is sub-optimal it is the easiest way to get saquery support to the
    other diags.
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 80628857886b0b26182fcf4e5d17f3c72a90d8b1
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Thu Jun 2 00:13:38 2011 -0700

    infiniband-diags: saquery; remove "result" global
    
    make struct sa_query_result a paramenter of sa_query.
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit c06655b88bc1b88f3aa42be4d1306b4fa42e3b47
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Tue Jul 12 11:34:36 2011 -0700

    infiniband-diags: change perl install to vendorlib
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit dee28c9a36941f6c2f8ae69f4a574984254afeb4
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Tue Jun 28 17:50:37 2011 -0700

    infiniband-diags: configure.in; check for more recent function in libibmad
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 1098eac2138a533e5fdbdfffbe4837763b78ba37
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Tue Jul 12 11:35:04 2011 -0700

    infiniband-diags: Add sysconfdir to spec for config files
    
    commit cbe10407a14e57c8febe6e039ae617737f0b6e0f added a configuration file
    directory in sysconfdir.  I missed this in the spec file.
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit c8a3e7bf94498459aad16cd298268e7767e9e9ed
Author: Hal Rosenstock <hal at dev.mellanox.co.il>
Date:   Thu Jul 7 09:50:12 2011 -0700

    infiniband-diags: Initial changes for extended speed support in libibmad
    
    Need larger buffer for mad_dump_portinfo due to additional extended
    speed fields
    
    Signed-off-by: Hal Rosenstock
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 0138f443fc02c3c650a496db851777221b37e74c
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Wed Jul 6 14:32:08 2011 -0700

    infiniband-diags: Remove reference to OpenSM from COPYING
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 46b1ba489d6ed3bde6a60c95d07233b67439e4f8
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Wed Jun 1 21:49:57 2011 -0700

    infiniband-diags: add package requires to spec file.
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 291a922cbcf246e15f0b71ef5d467c6e8bebb6d2
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Sun May 29 18:01:31 2011 -0700

    infiniband-diags: test for libosmcomp with a function that is used in the code
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit e9d099eda47f77d456996ce2fc385423ba19cbc0
Author: Hal Rosenstock <hal at dev.mellanox.co.il>
Date:   Mon Jun 20 06:00:56 2011 -0700

    infiniband-diags/ibnetdiscover.c: Fix typo in help
    
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 25fad278d4b8a808da5fe0e2ae7042ba18e74fdc
Author: Hal Rosenstock <hal at dev.mellanox.co.il>
Date:   Thu Jun 16 13:52:43 2011 -0700

    infiniband-diags/ibqueryerrors.c: Fix typo in help
    
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 22c5087c091b895507882eec85d6b57b641e637f
Author: Hal Rosenstock <hal at dev.mellanox.co.il>
Date:   Wed Jun 8 05:47:34 2011 -0700

    infiniband-diags/libibnetdisc/ibnetdisc_cache.c: Fix a couple of memory leaks
    
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 2a75c3e874e0d5edaaf84085f94fc65cd7c5a5be
Author: Hal Rosenstock <hal at dev.mellanox.co.il>
Date:   Wed Jun 8 05:47:15 2011 -0700

    infiniband-diags/libibnetdisc/ibnetdisc.c: Fix possible overrun of path
    
    when path->cnt is 63 in add_port_to_dpath
    
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 3364bcd41ec12c357c0510ac86a0cbb0313ca2d6
Author: Hal Rosenstock <hal at dev.mellanox.co.il>
Date:   Wed Jun 8 05:57:55 2011 -0700

    infiniband-diags/ibportstate.c: Fix sizeof
    
    It shouldn't be sizeof the pointer but this doesn't affect execution
    since this parameter is not used by mad_dump_portstates
    
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 1004b7f967df8a09e82d986124d1881b94dcb370
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Fri May 13 22:28:55 2011 -0700

    infiniband-diags: perfquery; Support PortCountersExtendedNoIETF
    
    Changes since V1:
    fix typo
       if (cap_mask & IB_PM_EXT_WIDTH_NOIETF_SUP) {
    to
    	if (cap_mask & IB_PM_EXT_WIDTH_SUPPORTED) {
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 5ef9bfa5d30baca408f310630de55aa1f0ecfc33
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Thu May 12 17:31:15 2011 -0700

    infiniband-diags: perfquery; print cap_mask for information
    
    Also fix cap_mask endianess in error print
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 82849a8212253c7c91ec6ce3ef15655e1c29b5b1
Author: Hal Rosenstock <hal at dev.mellanox.co.il>
Date:   Fri May 27 10:52:05 2011 -0700

    infiniband-diags/saquery.c: Fix SA_ERR_UNKNOWN define
    
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit ca54411f41b9192918c971a6a58b373e11e47919
Author: Hal Rosenstock <hal at dev.mellanox.co.il>
Date:   Wed May 25 05:30:06 2011 -0700

    infiniband-diags/configure.in: Support override for IBPATH
    
    Basing IBPATH on sbindir is not always what is desired.
    Allow for override of IBPATH, when this is not the case.
    
    Signed-off-by: Doron Tsur <doront at mellanox.co.il>
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 1a2ec7c386ae0ee749ac7b66ed0337b9fe1e1f5f
Author: Hal Rosenstock <hal at dev.mellanox.co.il>
Date:   Tue May 24 11:26:33 2011 -0700

    infiniband-diags/libibnetdisc/ibnetdisc.c: Better error message
    
    include node GUID and port number
    
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 87a30707bb36164a11dd1dd24087ca6bd3a333d1
Author: Eli Dorfman <elido at dev.mellanox.co.il>
Date:   Thu Apr 28 02:09:36 2011 -0700

    infiniband-diags/vendstat: Fixed general info query
    
    Fixed general info query
    
    There was no output when the query succeeded because the if statement was
    incomplete
    
    Signed-off-by: Eli Dorfman <elido at mellanox.com>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 1e406cb50f406a769afbbf806f984775a10dac4d
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Wed Apr 27 01:07:59 2011 -0700

    infiniband-diags: ibqueryerrors; add --counters option
    
    Display the data counters (optionally extended data counters) for all ports in the fabric.
    
    Chages in V2:
    Only print Unicast/Multicast fields when IsExtendedWidthSupported is indicated.
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 33a76020297553a5fad0f480e41f6ee9d86f12c7
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Tue Apr 26 22:59:15 2011 -0700

    infiniband-diags: ibqueryerrors --data; show/clear PortCountersExtended when supported
    
    Chages in V2:
    Only print/clear Unicast/Multicast fields when IsExtendedWidthSupported is
    indicated.
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 214bb92d11e93c76276db471ce88423d32c531a5
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Tue Apr 26 22:18:27 2011 -0700

    infiniband-diags: ibqueryerrors; use #defines for CapabilityMask
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 3387935ce91193fc7a3d7cdd9adea124f71a7640
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Mon Apr 25 12:39:12 2011 -0700

    infiniband-diags: ibqueryerrors; add ibcheckerrors like summary
    
    ibcheckerrors reports a summary of nodes checked, node errors, port checked, and
    port errors.  Track and print same as a summary.
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit cbe10407a14e57c8febe6e039ae617737f0b6e0f
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Wed Apr 27 10:43:01 2011 -0700

    infiniband-diags: ibqueryerrors; add error thresholds
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 53ac239ede48d6a1df8ed1f048cebe2eb2dc38e4
Author: Hal Rosenstock <hal at dev.mellanox.co.il>
Date:   Thu Apr 28 07:47:16 2011 -0700

    infiniband-diags/perfquery.c: Use ib_types.h defines for CapabilityMask
    
    rather than hard coded values now that these have been added to ib_types.h
    
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 42b5389f870c192627c22470298f8f97764b5979
Author: Hal Rosenstock <hal at dev.mellanox.co.il>
Date:   Wed Apr 27 12:48:15 2011 -0700

    infiniband-diags/ibnetdiscover.c: Eliminate blank line when sysimgguid is 0
    
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit d5d44d167696eeffcb31e941ded9da76566dde6d
Author: Hal Rosenstock <hal at dev.mellanox.co.il>
Date:   Wed Apr 27 11:17:46 2011 -0700

    infiniband-diags/libibnetdisc/ibnetdisc.c: Handle calloc failure
    
    in recv_node_info
    
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 32c0166f2f3afe68a599b107133ea6e6c6e72edd
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Wed Apr 27 10:08:03 2011 -0700

    infiniband-diags: fix "dist" target and subsequent rpm building
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 5f9facd634ed8f95d493c78dec5c1bc12795fbee
Author: Marcus Epperson <mrepper at sandia.gov>
Date:   Mon Apr 25 19:55:22 2011 -0700

    infiniband-diags/ibnetdiscover: Make --ports option use remap_node_name()
    
    Signed-off-by: Marcus Epperson <mrepper at sandia.gov>
    Signed-off-by: Jim Schutt <jaschut at sandia.gov>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 085432de49bcf6ebbcb927e2cac53da32cc9be94
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Thu Apr 21 14:47:03 2011 -0700

    infiniband-diags: improve backwards/standalone compatibility
    
    specifically allow for umad_port_t to not have link_layer
    Furthermore "mad.h" should not have libibnetdisc OS specific defines.
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit a398a098d0c21f0993cd3b8e3cd7485d87d6dff8
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Sun Apr 17 03:06:21 2011 -0700

    infiniband-diags: iblinkinfo; remove non-supported -c option from man page
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit a8c7126ff8cafc828ddbfe3708d25861e5440056
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Tue Mar 29 17:48:41 2011 -0700

    infiniband-diags: saquery, clean up error code/return types
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit ef2c2d6732c2f4e92a30e33e1bb4911eddd65223
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Wed Apr 13 09:10:34 2011 -0700

    infiniband-diags: saquery, properly free mad in get_and_dump_any_records
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 6df1fdd5aeb16fe17f08b5693b79326e8d78c7d2
Author: Hal Rosenstock <hal at dev.mellanox.co.il>
Date:   Sat Apr 9 15:22:02 2011 +0000

    infiniband-diags: Make sure buffers are set to zero before calling xxx_query_via
    
    where xxx is smp and pma. This is a cosmetic change based on
    IBA 1.2.1 vol 1 p.725 line 9:
    
    When constructing a response MAD that contains all or part of
    the corresponding request MAD, it is acceptable to include the
    contents of reserved fields in the request MAD in the response
    MAD without regard to their content. That is, such fields need not
    be set to zero in the response MAD.
    
    Signed-off-by: Aviad Yehezkel <aviadye at mellanox.co.il>
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>

commit a57e627722a5cad227baaae8de22b0af1438008d
Author: Hal Rosenstock <hal at dev.mellanox.co.il>
Date:   Fri Apr 1 18:38:50 2011 +0000

    infiniband-diags.spec.in: Remove duplication of ibdiscover.pl
    
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 9f91f2a277ade5875af43beb9ae246b9534d8279
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Thu Mar 17 17:34:52 2011 -0700

    infiniband-diags: saquery; clean up name/lid processing
    
    For NodeRecord querys in particular if a name was not found all NodeRecords
    were printed.  Correct behavior is to report "node not found".
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 1ee5bfabda30ae61ac869c380bbfe4bce3d7de1c
Author: Hal Rosenstock <hal at mellanox.com>
Date:   Mon Apr 26 14:27:32 2010 -0400

    infiniband-diags/saquery: Add GUIDInfoRecord support
    
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 7596207a1810dd7c5168469b0c3afd86aca8ae50
Author: Jason Gunthorpe <jgunthorpe at obsidianresearch.com>
Date:   Tue Mar 22 15:11:45 2011 -0700

    Fix ibdatacounters
    
    Commit fb3b1e753d527faa08f863a55f7f8392fb01f2ed switched the call
    to ibdatacounts with ibcheckerrs which breaks the point of the script,
    put it back.
    
    Signed-off-by: Jason Gunthorpe <jgunthorpe at obsidianresearch.com>

commit 568a1175a1089ebe8ee2d9b6e57086398219ba38
Author: Jason Gunthorpe <jgunthorpe at obsidianresearch.com>
Date:   Tue Mar 22 14:25:59 2011 -0700

    Fix missing $IBPATH in ibdatacounts
    
    Otherwise it blows up if smpquery is not in the search path.
    
    Signed-off-by: Jason Gunthorpe <jgunthorpe at obsidianresearch.com>

commit a6abfa00de4e45cedde3616e03de37b3a3430bf2
Author: Tamir Ronen <tamirr at voltaire.com>
Date:   Mon Feb 14 15:17:15 2011 -0800

    add support for ibnetdiscover grouping for Mellanox switches
    
        Group Mellanox switches to the same chassis using SYSTEM_GUID
        Use the node description format:
        'MF0;<system name>:<system type>/<system slot name>[:board type]/U<node index>'
        to identify system type, slot type Line/Spine, slotnum and anafanum.
        Map Line ports 1-18 as external ports 1-18.

commit 6087f0dd22ff01f2848e1bb879751387575bc0eb
Merge: 450de0f ff57b27
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Mon Feb 14 16:42:23 2011 -0800

    Merge branch 'master' of git://git.openfabrics.org/~alexnetes/infiniband-diags

commit 450de0f8196a855bfa1f6da7310dc399088a38a5
Author: Albert Chu <chu11 at llnl.gov>
Date:   Wed Apr 21 17:04:02 2010 -0700

    support --filterdownports in iblinkinfo
    
    Signed-off-by: Albert Chu <chu11 at llnl.gov>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit c9adf42231d0bb1fc09d361c828bbb54b3f3b2f2
Author: Albert Chu <chu11 at llnl.gov>
Date:   Tue Apr 20 10:13:05 2010 -0700

    Add lid and node description diff options for --diffcheck in iblinkinfo
    
    Signed-off-by: Albert Chu <chu11 at llnl.gov>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 20af5c37bbdb21482f2f35a0ad087e143a207c4b
Author: Albert Chu <chu11 at llnl.gov>
Date:   Tue Apr 20 09:53:53 2010 -0700

    support --diffcheck in iblinkinfo
    
    Signed-off-by: Albert Chu <chu11 at llnl.gov>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit 1950038c3f71bb1eaecb77516f2022c13189fdcc
Author: Albert Chu <chu11 at llnl.gov>
Date:   Mon Apr 19 10:36:54 2010 -0700

    add --diff support to iblinkinfo
    
    Signed-off-by: Albert Chu <chu11 at llnl.gov>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit d58cb634194c80b91bac8caf6ab34d7a1b7408fc
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Fri Jul 30 14:26:39 2010 -0700

    ibnetdisc.c: Fix partial scan of the fabric.
    
       When max_hops was specified it did not result in a correct limited scan of
       the fabric.
       In addition the -S and -D options of iblinkinfo/ibqueryerrors should by
       default only scan 1 hop from the node specified to allow for faster
       processing.
    
    Signed-off-by: Ira Weiny <weiny2 at hype137.llnl.gov>
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

commit d60d71eeb9890e932472c415164b1ff400d73b12
Author: Jason Gunthorpe <jgunthorpe at obsidianresearch.com>
Date:   Mon Feb 14 10:36:13 2011 -0800

    The shell scripts use bashism, so use bash directly.
    
    Otherwise it blows up on distributions that don't use bash as /bin/sh,
    like Debian and Ubuntu. One could probably just remove the bashisms, but
    that is much harder.
    
    An example error is:
    ibswitches: 5: Syntax error: "(" unexpected
    
    Signed-off-by: Jason Gunthorpe <jgunthorpe at obsidianresearch.com>

commit ff57b27e8ec02f4f92e50cbda5caa4b8e6035823
Author: Alex Netes <alexne at voltaire.com>
Date:   Mon Feb 14 11:56:21 2011 +0200

    infiniband-diags: package versions update
    
    infiniband-diags package versions update.
    
    Signed-off-by: Alex Netes <alexne at voltaire.com>

commit 6edf9877048fd050361fbccdfce69fc2c73b1b06
Author: Alex Netes <alexne at voltaire.com>
Date:   Mon Feb 14 11:53:59 2011 +0200

    infiniband-diags: update shared library versions
    
    Update shared library version in accordance with recent changes.
    
    Signed-off-by: Alex Netes <alexne at voltaire.com>

commit b1e4531e2d10a8404cc7873c6f899494cef236c4
Author: Alex Netes <alexne at voltaire.com>
Date:   Thu Feb 3 18:25:19 2011 +0200

    Makefile: ChangeLog and version generation script path fix
    
    Move ChangeLog and version generation script into top source directory and fix
    path in Makefile accordingly.
    
    Signed-off-by: Alex Netes <alexne at voltaire.com>

commit b260cb4f276b756ded39455969028bcdcd49f60e
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Wed Dec 22 11:47:07 2010 -0800

    Further timeout paramater verification (Was: [PATCH] infiniband-diags: Verify timeout value specified to diagnostics)
    
    On Mon, 20 Dec 2010 13:57:36 -0800
    Jay Fenlason <fenlason at redhat.com> wrote:
    
    > Sorry if you get this more than once, I seem to have outgoing mail misconfiguration here.
    >
    > On Wed, Dec 15, 2010 at 11:47:09AM -0800, Ira Weiny wrote:
    > >
    > > Verify timeout value specified to diagnostics
    > >
    > >
    > > Signed-off-by: Ira Weiny <weiny2 at hype137.llnl.gov>
    > > ---
    > >  infiniband-diags/src/ibdiag_common.c |   10 +++++++---
    > >  1 files changed, 7 insertions(+), 3 deletions(-)
    > >
    > > diff --git a/infiniband-diags/src/ibdiag_common.c b/infiniband-diags/src/ibdia
    > +g_common.c
    > > index 99861f1..8ccf2fc 100644
    > > --- a/infiniband-diags/src/ibdiag_common.c
    > > +++ b/infiniband-diags/src/ibdiag_common.c
    > > @@ -175,9 +175,13 @@ static int process_opt(int ch, char *optarg)
    > >               ibd_dest_type = IB_DEST_GUID;
    > >               break;
    > >       case 't':
    > > -             val = strtoul(optarg, 0, 0);
    > > -             madrpc_set_timeout(val);
    > > -             ibd_timeout = val;
    > > +             val = (int)strtol(optarg, NULL, 0);
    > > +             if (val > 0) {
    > > +                     madrpc_set_timeout(val);
    > > +                     ibd_timeout = val;
    > > +             } else
    > > +                     IBERROR("Invalid timeout \"%s\".  Timeout requires a "
    > > +                             "positive integer value.", optarg);
    > >               break;
    > >       case 's':
    > >               /* srcport is not required when resolving via IB_DEST_LID */
    > > --
    > > 1.5.4.5
    >
    > This only partially detects invalid timeouts.  For example, timeouts
    > of "123skidoo" or 1234534587347895789457897897894578978912902393 will
    > be accepted but will not work as expected.  To fully test the
    > conversion, you need to do something more like:
    >
    >   long val;
    >   char *endp;
    >
    >   ...
    >   errno = 0;
    >   val = strtol ( optarg, &endp 0 );
    >   if ( errno || ( endp && *endp != '\0' ) || val < 0 || val > INT_MAX ) {
    >         /* invalid timeout detected */
    >   ...
    >
    > All of the tests are required to detect invalid inputs.
    >
    > 		-- JF
    
    Patch below,
    Ira
    
    From: Ira Weiny <weiny2 at hype137.llnl.gov>
    Date: Wed, 22 Dec 2010 11:40:33 -0800
    Subject: [PATCH] Further timeout paramater verification
    
    suggested by Jay Fenlason <fenlason at redhat.com>
    
    Signed-off-by: Ira Weiny <weiny2 at hype137.llnl.gov>
    Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>

commit 298998c77dad10630608374ed1915b506008e79b
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Wed Dec 15 11:47:09 2010 -0800

    infiniband-diags: Verify timeout value specified to diagnostics
    
    Verify timeout value specified to diagnostics
    
    Signed-off-by: Ira Weiny <weiny2 at hype137.llnl.gov>
    Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>

commit 8ab2e41e866c27f2ce605fa0bc16b52cd96babf9
Author: Ira Weiny <weiny2 at llnl.gov>
Date:   Tue Aug 3 10:40:56 2010 -0700

    libibmad/fields.c: Change all PortCounter names to match the Specification
    
    Change from V1:
       Add name change to scripts in infiniband-diags
    
    Signed-off-by: Ira Weiny <weiny2 at llnl.gov>
    Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>

commit 07b4b1afa21a6b4157a69e82b95ad1bc709326c8
Author: Hal Rosenstock <hal at dev.mellanox.co.il>
Date:   Wed Oct 27 08:47:07 2010 -0400

    infiniband-diags/iblinkinfo.c: Limit some queries to switches
    
    infiniband-diags/iblinkinfo.c: Limit certain queries to switches
    
    iblinkinfo man page says:
    DESCRIPTION
            iblinkinfo reports the link info for each port of each switch
    active in
            the IB fabric.
    
    OPTIONS
            -S <guid>
                   Output only the switch specified by <guid> (hex format)
    
            -D <direct_route>
                   Output only the switch specified by the direct route path.
    
    Queries by DR path or GUID should (also) be limited to switches.
    
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>
    Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>

commit 0d7e988df53e6ebf1b86d24cebab308527c811ac
Author: Hal Rosenstock <hal at dev.mellanox.co.il>
Date:   Wed Oct 27 09:06:36 2010 -0400

    infiniband-diags/saquery.c: In dump_one_mcmember_record, fix flow label endian
    
    Already in host endian
    
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>
    Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>

commit 3d00c3eb9ae7019dbb8d9e4c10fdc54af9855dd2
Author: Hal Rosenstock <hnrose at comcast.net>
Date:   Tue Sep 14 11:10:16 2010 -0400

    infiniband-diags/ibtracert: Eliminate direct route (-D) option
    
    Direct route does not make sense as an ibtracert option so eliminate it.
    
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>
    Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>

commit c58dcaa92c3cce03f03a5d4e6fc6e5197ed9674d
Author: Yevgeny Kliteynik <kliteyn at mellanox.co.il>
Date:   Mon Oct 4 12:16:43 2010 +0200

    ibstat.c: fix core dump if wrong port phys state is reported
    
    Signed-off-by: Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>
    Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>

commit f5178760dcdaeecaad9f98a28ed2d32c74908704
Author: Jason Gunthorpe <jgunthorpe at obsidianresearch.com>
Date:   Thu Oct 7 16:33:01 2010 -0600

    Fix autotools to include the necessary M4 files
    
    Otherwise running autogen.sh with a new version of autotools and then
    building on a system with an older version tends to explode.
    Unfortunately this is sometimes necessary since the new version is
    required by the package.
    
    This is how GNU envisions this mess works at least..
    
    Signed-off-by: Jason Gunthorpe <jgunthorpe at obsidianresearch.com>
    Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>

commit 782fd92025d3c97d8822e95be239edd7553c7b80
Author: Eli Dorfman (Voltaire) <dorfman.eli at gmail.com>
Date:   Sun Sep 5 11:30:37 2010 +0300

    inifiband-diags: Support Voltaire switch ISR4200
    
    Support Voltaire switch (ISR4200) grouping.
    
    Signed-off-by: Eli Dorfman <elid at voltaire.com>
    Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>

commit 5578a9c0b4b8d614880840305badfc81ef5a33d9
Author: Eli Dorfman (Voltaire) <dorfman.eli at gmail.com>
Date:   Sun Sep 5 11:28:57 2010 +0300

    infiniband-diags: Do not exit when unexpected node found
    
    Show error message but do not exit when unexpected node is found.
    
    Signed-off-by: Eli Dorfman <elid at voltaire.com>
    Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>

commit 843d2bb428f5e9fda3628252abcedd69300ee9c0
Author: Sasha Khapyorsky <sashak at voltaire.com>
Date:   Sat Sep 4 14:15:33 2010 +0300

    management: packages versions update
    
    Management packages versions update.
    
    Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>

commit 3eabf4227a7267c52e7be496ffdfb857018c6c83
Author: Sasha Khapyorsky <sashak at voltaire.com>
Date:   Sat Sep 4 14:13:06 2010 +0300

    management: update shared library versions
    
    Update shared library version in accordance with recent changes.
    
    Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>

commit c02bdb17ef04162968e88379b5ab86f10935ba9b
Author: Hal Rosenstock <hnrose at comcast.net>
Date:   Wed Aug 25 14:08:02 2010 -0400

    infiniband-diags/ibnetdiscover: Fix handling of CA ports in recv_port_info
    
    When multiple ports on the same CA are connected to the same subnet and
    an ibnetdiscover is initiated from one of them, the discovery continues
    past the other CA port and an error occurs.
    
    The error is:
    src/query_smp.c:188; umad (DR path slid 0; dlid 0; 0,1,20,2 Attr0x11:0) bad status 110; Connection timed out
    
    Fix this by saving the initiating port number in the fabric structure
    and using that rather than local_port for the comparison in
    recv_port_info.
    
    Signed-off-by: Hal Rosenstock <hal at mellanox.com>
    Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>

commit 843a0072a86afe85e053dceb402c2d62bb38e002
Author: Doron Shoham <dorons at voltaire.com>
Date:   Thu Aug 26 16:14:16 2010 +0300

    ibnetdiscover: add '-f' flag to show full information (ports' speed and width).
    
    add '-f' flag to show full information (ports' speed and witdh).
    mainly to work with ibsim (using links real speed and width).
    
    Signed-off-by: Doron Shoham <dorons at voltaire.com>
    Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>

commit a387f265398c671e9067e055bbebaa634fb4aa49
Author: Sasha Khapyorsky <sashak at voltaire.com>
Date:   Sun Aug 1 20:26:11 2010 +0300

    infiniband-diags/ibstat: convert to PRIx64 macros GUID printing
    
    Convert to using PRIx64 macros for printing GUID values.
    
    Pointed out by Irena Kruchkovsky.
    
    Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>




More information about the ofw mailing list