[ofw] ipoib_ndis6_cm patches so it will compile

Alex Naslednikov xalex at mellanox.co.il
Wed Feb 2 01:41:41 PST 2011


Hi Stan,
You fix was successfully applied at 3088 together with 2 previously published patches.
Thank you for the fix.

XaleX

-----Original Message-----
From: Smith, Stan [mailto:stan.smith at intel.com] 
Sent: Wednesday, February 02, 2011 2:50 AM
To: Alex Naslednikov
Subject: ipoib_ndis6_cm patches so it will compile

Hi Alex,
  It would be useful to do a test compile after a checkin.

The extra field send_dir was removed in favor of always initializing the field 'send_qp' to be the UD qp. 'send_qp' is only reset when CM mode is enabled with an RC qp available; unless you want to send over an RC connection, send_qp is 'always' set to the UD qp value.

Missing p_port in call to ipoib_endpt_create().

Function ipchksum() is defined as static.

Please apply these patches so ipoib_ndis6_cm will compile without errors.

Thank you,

Stan.

--- A/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp	Tue Feb 01 16:39:15 2011
+++ B/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp	Tue Feb 01 16:35:51 2011
@@ -436,7 +436,7 @@
 	IN PNDIS_TCP_LARGE_SEND_OFFLOAD_NET_BUFFER_LIST_INFO p_lso_info,
 	IN				NET_BUFFER					*p_netbuf);
 
-unsigned short ipchksum(unsigned short *ip, int len);
+static unsigned short ipchksum(unsigned short *ip, int len);
 
 static inline void
 	ipoib_print_ip_hdr( 
@@ -5209,11 +5209,9 @@
 											buf_len );
 		if( status != NDIS_STATUS_SUCCESS )
 			return status;
-		p_desc->send_dir = SEND_UD_QP;
 		break;
 		
 	case IP_PROT_ICMP:
-		p_desc->send_dir = SEND_UD_QP;
 		break;
 		
 	case IP_PROT_ICMPV6:
@@ -5224,7 +5222,6 @@
 		if( status != NDIS_STATUS_PENDING ) {
 			return status;
 		}
-		p_desc->send_dir = SEND_UD_QP;
 		break;
 		
 	default:
@@ -5368,7 +5365,6 @@
 	p_desc->send_wr[0].local_ds[1].lkey = s_buf->p_port->ib_mgr.lkey;
 	p_desc->send_wr[0].wr.num_ds = 2;
 	p_desc->send_wr[0].wr.p_next = NULL;
-	p_desc->send_dir = SEND_UD_QP;
 
 	IPOIB_EXIT( IPOIB_DBG_SEND );
 	return STATUS_SUCCESS;
@@ -9496,8 +9492,9 @@
 		/*
 		 * Create the endpoint.
 		 */
-		*pp_src = ipoib_endpt_create( &p_new_hw_addr->gid,
-									  p_wc->recv.ud.remote_lid, 														   
+		*pp_src = ipoib_endpt_create( p_port,
+									  &p_new_hw_addr->gid,
+									  p_wc->recv.ud.remote_lid,
 									  ipoib_addr_get_qpn( p_new_hw_addr ) );
 		
 		if( !*pp_src )




More information about the ofw mailing list