[ofw] [summy patch] Allow basic functionality of RoCE to work

Hefty, Sean sean.hefty at intel.com
Mon Jan 3 08:36:21 PST 2011


+             MLX4_PRINT(TRACE_LEVEL_WARNING, MLX4_DBG_DRV,("setting gid is 0x%x 0x%x 0x%x 0x%x 0x%x 0x%x 0x%x 0x%x",
+                                             tmpgids[0].raw[8],
+                                             tmpgids[0].raw[9],
+                                             tmpgids[0].raw[10],
+                                             tmpgids[0].raw[11],
+                                             tmpgids[0].raw[12],
+                                             tmpgids[0].raw[13],
+                                             tmpgids[0].raw[14],
+                                             tmpgids[0].raw[15]
+                             ));

Use inet_ntop() for displaying gids.


Index: inc/user/iba/ibat.h
===================================================================
--- inc/user/iba/ibat.h    (revision 6962)
+++ inc/user/iba/ibat.h (working copy)
@@ -45,6 +45,9 @@
 namespace IBAT
 {

+HRESULT Init();

I never saw where this was used.

Index: ulp/libibverbs/examples/pingpong.c
===================================================================
--- ulp/libibverbs/examples/pingpong.c                (revision 6962)
+++ ulp/libibverbs/examples/pingpong.c             (working copy)
@@ -50,3 +50,25 @@

                return attr.lid;
 }
+
+void str2gid(char *grh, union ibv_gid *gid)

use inet_pton - see inc/user/linux.  These calls should be ported to the kernel if needed.

Index: ulp/nd/user/NdConnector.cpp
===================================================================
--- ulp/nd/user/NdConnector.cpp           (revision 6962)
+++ ulp/nd/user/NdConnector.cpp        (working copy)
@@ -247,6 +247,20 @@
     return hr;
 }

+    ib_gid_t SwapGid(UINT64 In1, UINT64 In2) {

I don't understand the need for this call.

+#if 0

#if 0 should be replaced with left-click, highlight select, press the delete key

Index: ulp/nd/user/NdProv.cpp
===================================================================
--- ulp/nd/user/NdProv.cpp       (revision 6962)
+++ ulp/nd/user/NdProv.cpp    (working copy)
@@ -253,6 +253,18 @@
         return S_OK;
     }

+    UINT64 SwapGuid(UINT64 In) {

Use ntohll and htonll
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20110103/191e2937/attachment.html>


More information about the ofw mailing list