[ofw] [Patch] IPoIB: Comment GUIDs in guid2mac_table

Fab Tillier ftillier at microsoft.com
Fri Jan 21 13:02:18 PST 2011


Committed in revision 3078.

-Fab

Fab Tillier wrote on Tue, 11 Jan 2011 at 16:22:45

> Smith, Stan wrote on Tue, 11 Jan 2011 at 16:10:36
> 
>> Do we need/want a svr2003/ipoib version also?
> 
> IMO no, because the older IPoIB driver is (should be) in maintenance
> mode...  Though really, this translation table could well be defined in a
> shared header.  Better yet would be to store the table in the registry, so that
> additional GUIDs can be added without having to rebuild the driver...
> 
> But that's a project for another day.  I just had this lying around my sandbox
> and figured someone else might find the comments useful.
> 
> -Fab
> 
>> 
>> Fab Tillier wrote:
>>> Commented the owners of various entries in the table...
>>> 
>>> Signed-off-by: Fab Tillier <ftillier at microsoft.com>
>>> 
>>> Index: ulp/ipoib_NDIS6_CM/kernel/ipoib_xfr_mgr.cpp
>>> 
>>> 
> ===================================================================
> ---
>>> ulp/ipoib_NDIS6_CM/kernel/ipoib_xfr_mgr.cpp       (revision 3068) +++
>>> ulp/ipoib_NDIS6_CM/kernel/ipoib_xfr_mgr.cpp       (working copy) @@
>>> -41,35 +41,35 @@
>>> 
>>> 
>>>  const ipoib_guid2mac_translation_t guid2mac_table[] = {
>>> -     {0x00, 0x30, 0x48, 0xE7},
>>> -     {0x00, 0x05, 0xAD, 0xE7},
>>> -     {0x00, 0x18, 0x8B, 0xE7},
>>> -     {0x00, 0x1A, 0x4B, 0xE7},
>>> -     {0x00, 0x17, 0x08, 0xE7},
>>> -     {0x00, 0x1E, 0x0B, 0xE7},
>>> +     {0x00, 0x30, 0x48, 0xE7},       //SuperMicro
>>> +     {0x00, 0x05, 0xAD, 0xE7},       //Topspin
>>> +     {0x00, 0x18, 0x8B, 0xE7},       //Dell
>>> +     {0x00, 0x1A, 0x4B, 0xE7},       //HP
>>> +     {0x00, 0x17, 0x08, 0xE7},       //HP
>>> +     {0x00, 0x1E, 0x0B, 0xE7},       //HP
>>> 
>>> -     {0x00, 0x03, 0xBA, 0xE7},
>>> -     {0x00, 0x05, 0xAD, 0xE7},
>>> -     {0x00, 0x0D, 0x9D, 0xE7},
>>> -     {0x00, 0x11, 0x0A, 0xE7},
>>> -     {0x00, 0x11, 0x85, 0xE7},
>>> -     {0x00, 0x12, 0x79, 0xE7},
>>> -     {0x00, 0x13, 0x21, 0xE7},
>>> -     {0x00, 0x14, 0x38, 0xE7},
>>> -     {0x00, 0x16, 0x35, 0xE7},
>>> -     {0x00, 0x17, 0x08, 0xE7},
>>> -     {0x00, 0x17, 0xA4, 0xE7},
>>> -     {0x00, 0x18, 0x8B, 0xE7},
>>> -     {0x00, 0x18, 0xFE, 0xE7},
>>> -     {0x00, 0x19, 0xBB, 0xE7},
>>> -     {0x00, 0x1A, 0x4B, 0xE7},
>>> -     {0x00, 0x1B, 0x78, 0xE7},
>>> -     {0x00, 0x1E, 0x0B, 0xE7},
>>> -     {0x00, 0x22, 0x64, 0xE7},
>>> -     {0x00, 0x23, 0x7D, 0xE7},
>>> -     {0x00, 0x25, 0x90, 0xE7},
>>> -     {0x00, 0x30, 0x48, 0xE7},
>>> -     {0x00, 0x80, 0x5F, 0xE7},
>>> +     {0x00, 0x03, 0xBA, 0xE7},       //Oracle
>>> +     {0x00, 0x05, 0xAD, 0xE7},       //Topspin
>>> +     {0x00, 0x0D, 0x9D, 0xE7},       //HP
>>> +     {0x00, 0x11, 0x0A, 0xE7},       //HP
>>> +     {0x00, 0x11, 0x85, 0xE7},       //HP
>>> +     {0x00, 0x12, 0x79, 0xE7},       //HP
>>> +     {0x00, 0x13, 0x21, 0xE7},       //HP
>>> +     {0x00, 0x14, 0x38, 0xE7},       //HP
>>> +     {0x00, 0x16, 0x35, 0xE7},       //HP
>>> +     {0x00, 0x17, 0x08, 0xE7},       //HP
>>> +     {0x00, 0x17, 0xA4, 0xE7},       //HP
>>> +     {0x00, 0x18, 0x8B, 0xE7},       //Dell
>>> +     {0x00, 0x18, 0xFE, 0xE7},       //HP
>>> +     {0x00, 0x19, 0xBB, 0xE7},       //HP
>>> +     {0x00, 0x1A, 0x4B, 0xE7},       //HP
>>> +     {0x00, 0x1B, 0x78, 0xE7},       //HP
>>> +     {0x00, 0x1E, 0x0B, 0xE7},       //HP
>>> +     {0x00, 0x22, 0x64, 0xE7},       //HP
>>> +     {0x00, 0x23, 0x7D, 0xE7},       //HP
>>> +     {0x00, 0x25, 0x90, 0xE7},       //SuperMicro
>>> +     {0x00, 0x30, 0x48, 0xE7},       //SuperMicro
>>> +     {0x00, 0x80, 0x5F, 0xE7},       //HP
>>> 
>>>       {0x00, 0x00, 0x00, 0x00},
>>>  };
> _______________________________________________
> ofw mailing list
> ofw at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw



More information about the ofw mailing list