[ofw] [Patches 6-7/26][Core] [Gutils]Adjust code to remove Prefast errors and warning

Uri Habusha urih at mellanox.co.il
Thu Jun 23 04:34:50 PDT 2011


SB

-----Original Message-----
From: ofw-bounces at lists.openfabrics.org [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Smith, Stan
Sent: Wednesday, June 22, 2011 8:55 PM
To: Alex Naslednikov; ofw at lists.openfabrics.org
Subject: Re: [ofw] [Patches 6-7/26][Core] [Gutils]Adjust code to remove Prefast errors and warning

Is '#ifdef DRIVER' new?
[UH] It's already defined in SOURCES file

Why not use existing complib '#ifdef CL_KERNEL'  if ' RtlStringCchCopyA()' is not available in user mode?
[UH] I'm okay to  use CL_KERNEL for consistency 


+#ifdef DRIVER
+	RtlStringCchCopyA(
+		(char*)reg_svc_req.svc_rec.service_name,
+		sizeof(reg_svc_req.svc_rec.service_name),
+		DM_SVC_NAME
+		);	
+#else
 		strcpy_s(
 			(char*)reg_svc_req.svc_rec.service_name,
 			sizeof(reg_svc_req.svc_rec.service_name),
 			DM_SVC_NAME
 			);
-		
+#endif		

>-----Original Message-----
>From: Alex Naslednikov [mailto:xalex at mellanox.co.il]
>Sent: Sunday, June 19, 2011 5:27 AM
>To: Alex Naslednikov; ofw at lists.openfabrics.org; Smith, Stan
>Subject: RE: [ofw] [Patches 6-7/26][Core] [Gutils]Adjust code to remove Prefast errors and warning
>
>Prefast: add driver directives
>
>
>
>
>Alexander (XaleX) Naslednikov
>SW Networking Team
>Mellanox Technologies

_______________________________________________
ofw mailing list
ofw at lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw



More information about the ofw mailing list