[ofw] [PATCH] allow svr 2003 compilation

[Smith, Stan]

>-----Original Message-----
>From: Uri Habusha [mailto:urih at mellanox.co.il]
>Sent: Tuesday, June 28, 2011 11:25 AM
>To: Smith, Stan; Alex Naslednikov
>Cc: ofw at lists.openfabrics.org
>Subject: RE: [PATCH] allow svr 2003 compilation
>
>Hi Stan,
>
>I think we agreed to stop to support win 2003. Am I wrong?

Hello Uri,
  From the April 26th WWG meeting minutes:

>>Mellanox further clarified that no new development will occur for Server 2003 and XP InfiniHost HCA drivers.
>>Bug fixing will continue.
>>
>>WWG is considering not supplying winOFED installers for Server 2003, XP and IA64 - any heartburn?

Seems we never closed the decision loop about supporting Svr 2003; which leaves, per Mellanox comment, No new development for Svr 2003, although bug fixing will continue....which implies we still build for Svr 2003.

That said, if Mellanox is good with not supporting Svr 2003 build and releasing for Svr 2003............... AND Microsoft is good with this (Svr 2003 CCS support?) then we should just wipe the slate clean of Svr 2003 (as we have done for XP).

winOFED for Windows Server 2008(win7) family only, makes life much easier!

Eric or Fab, what say you?

Stan.

>
>-----Original Message-----
>From: ofw-bounces at lists.openfabrics.org [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Smith, Stan
>Sent: Tuesday, June 28, 2011 9:21 PM
>To: Alex Naslednikov
>Cc: ofw at lists.openfabrics.org
>Subject: [ofw] [PATCH] allow svr 2003 compilation
>
>Hello Alex,
>  Your patch did not compile for svr 2003 x86; I believe I captured in spirit what you wanted.
>
>Signed-off-by: stan smith <stan.smith at intel.com>
>
>--- C:/Users/scsmith/AppData/Local/Temp/al_dm.c-revBASE.svn000.tmp.c	Tue Jun 28 11:12:33 2011
>+++ C:/Users/scsmith/Documents/openIB-windows/SVN/gen1/trunk/core/al/al_dm.c	Tue Jun 28 11:13:03 2011
>@@ -765,17 +765,25 @@
>
> 		reg_svc_req.svc_rec.service_lease = 0xffffffff;  #ifdef CL_KERNEL
>-	RtlStringCchCopyA(
>-		(char*)reg_svc_req.svc_rec.service_name,
>-		sizeof(reg_svc_req.svc_rec.service_name),
>-		DM_SVC_NAME
>-		);
>+		RtlStringCchCopyA(
>+			(char*)reg_svc_req.svc_rec.service_name,
>+			sizeof(reg_svc_req.svc_rec.service_name),
>+			DM_SVC_NAME
>+			);
> #else
>+#ifdef NTDDI_WIN8
> 		strcpy_s(
> 			(char*)reg_svc_req.svc_rec.service_name,
> 			sizeof(reg_svc_req.svc_rec.service_name),
> 			DM_SVC_NAME
> 			);
>+#else
>+		strncpy(
>+			(char*)reg_svc_req.svc_rec.service_name,
>+			DM_SVC_NAME,
>+			sizeof(DM_SVC_NAME)
>+			);
>+#endif
> #endif
> 		reg_svc_req.svc_rec.service_gid = p_iou_port->port_gid;
> 		reg_svc_req.port_guid = p_iou_port->port_guid;
>