[ofw] removing the dpecial debug file

Fab Tillier ftillier at microsoft.com
Wed Jun 29 15:18:15 PDT 2011


Hefty, Sean wrote on Wed, 29 Jun 2011 at 15:03:03

>> Would you always put the extra debug parameters in the complib
>> structures, or remove the debug features that break ABI?
> 
> Probably both.  For example, my initial thoughts for cl_qlist.h are:
> 
> remove p_list from cl_list_item to save space
> remove all CL_ASSERTs
>   (assertions for NULL pointers aren't necessary,
>    just dereference and crash - same affect)
> keep the debug code in __cl_primitive_remove
>   (to force a crash if removed twice)

I'd just try to eliminate complib altogether, personally.  For qlist, I'd make it entirely inline, so that there is no ABI for it, then the debug/release code could be preserved.

-Fab



More information about the ofw mailing list