[ofw] removing the special debug file

[Uri Habusha]

Attached is the patch file.

I changed the sources and *.inx file

From: Smith, Stan [mailto:stan.smith at intel.com]
Sent: Wednesday, June 29, 2011 10:36 PM
To: Uri Habusha; Fab Tillier; ofw at lists.openfabrics.org
Subject: RE: removing the special debug file

Please see below.

From: Uri Habusha [mailto:urih at mellanox.co.il]
Sent: Wednesday, June 29, 2011 12:18 PM
To: Fab Tillier; Smith, Stan; ofw at lists.openfabrics.org
Subject: RE: removing the special debug file

No. in many places in build the linking is done with different files in release and in debug.

The summaries the work:

*         Need to fix the sources. Remove different file generation and link

*         Need to fix inf not copy the *d.dll files.

Regarding rc I'm not sure. When you use ndis.sys in debug and release you get the same file description. I don't think we need to act differently.

[stan] Just because MS did not do something, does not imply we should propagate their mistakes.
The .rc file tag makes it 'very' easy to distinguish Debug vs. Release, otherwise the only way you can tell the difference is if the file size (not 100% accurate).

Tagging the .rc file makes debug/release very, very easy to identify when both versions have the same filename!


I'll do the work and send the patch for review

From: Fab Tillier [mailto:ftillier at microsoft.com]
Sent: Wednesday, June 29, 2011 8:11 PM
To: Smith, Stan; Uri Habusha; ofw at lists.openfabrics.org
Subject: RE: removing the special debug file

Can we Just remove the debug DLLs from the INF file and be done with it?

-Fab

From: ofw-bounces at lists.openfabrics.org [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Smith, Stan
Sent: Wednesday, June 29, 2011 9:30 AM
To: Uri Habusha; ofw at lists.openfabrics.org
Subject: Re: [ofw] removing the special debug file

Hello Uri,
  I believe the current mode of operation is to copy-rename-replace the free version of the file with debug version of the file.

Removing the 'd' for debug filename convention will be a fair amount of work impacting 'many' build and release files.

That said, I personally have no problems with dropping the special debug name of the file.

I would request that all .rc files have the correctly working '#if DBG' with '#define VER_FILEDESCRIPTION_STR' containing some indication the version is Debug/Checked.
The absence of Debug/Checked would imply a free/released version of the module.

With the correct #define VER_FILEDESCRIPTION_STR definition, one can hold the mouse-point over the explorer filename and determine if the module is Debug or Free.
Fortunately many modules already support this functionality.

#if DBG
#define VER_FILEDESCRIPTION_STR                        "IP over InfiniBand (Connected Mode) NDIS 6 Miniport (Checked)"
#else
#define VER_FILEDESCRIPTION_STR                        "IP over InfiniBand (Connected Mode) NDIS 6 Miniport"
#endif

Who is going to do this conversion work?

Stan.

From: Uri Habusha [mailto:urih at mellanox.co.il]
Sent: Wednesday, June 29, 2011 1:21 AM
To: ofw at lists.openfabrics.org; Smith, Stan
Subject: removing the dpecial debug file

Currently the OFA build creates different files for debug and release version (i.e complib.dll for release and complibd.dll for debug).

I don't know what was the reason to do it in this way, but I  know that there is no other product that do it. If you wants to debug an issue you can install the debug version that contains the debug dll.

Using different names complicates our installation package and testing. I want to change the code to use same file name for debug and release.

Please let me know if there is any reason not doing it.

Thanks Uri

Uri Habusha
Windows SW Development Lead

Mellanox Technologies
P.OBox 586, Yokneam 20692
Israel



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20110630/c88aee0d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: _remove_debug_files.patch
Type: application/octet-stream
Size: 54985 bytes
Desc: _remove_debug_files.patch
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20110630/c88aee0d/attachment.obj>