[ofw] New bus driver

[Leonid Keller]

I've fixed the defines.
I'll answer about roce_get_mtu later.

From: Smith, Stan [mailto:stan.smith at intel.com]
Sent: Thursday, October 06, 2011 1:54 AM
To: Leonid Keller
Cc: ofw_list
Subject: RE: New bus driver

Hi Leo,
  Some preliminary results for the branches\mlx4\ code base.
After carefully merging the Head of the SVN tree (aka trunk\) with mlx4\, I was able to build x64 installers and test; going well at this time.
A quick code review while merging, I found 'roce_get_mtu()' function defined in ib_pack.h?
Seems like an unlikely place to define roce_get_mtu(), perhaps a more ROCE typed file could be found?

When building for IA64, I ran into the usage of '_AMD64_' conditionals. I would suggest replacing with standard MS predefined macros; we still support IA64.


--- C:/Users/scsmith/AppData/Local/Temp/eq.c-revBASE.svn000.tmp.c     Wed Oct 05 16:44:11 2011

+++ C:/Users/scsmith/Documents/openIB-windows/OFA_SVN/ofw/gen1/branches/mlx4/hw/mlx4/kernel/bus/net/eq.c     Wed Oct 05 16:17:03 2011

@@ -1252,7 +1252,7 @@

         return -EINVAL;

     }



-#ifndef AMD64

+#if _M_IX86

     _BitScanForward(&cpu_number_in_group, *affinity);

#else

     _BitScanForward64(&cpu_number_in_group, *affinity);


--- C:/Users/scsmith/AppData/Local/Temp/fw.c-revBASE.svn000.tmp.c     Wed Oct 05 16:44:46 2011

+++ C:/Users/scsmith/Documents/openIB-windows/OFA_SVN/ofw/gen1/branches/mlx4/hw/mlx4/kernel/bus/net/fw.c     Wed Oct 05 16:25:08 2011

@@ -1273,7 +1273,7 @@

    memset(inbox, 0, INIT_HCA_IN_SIZE);



     *((u8 *) mailbox->buf + INIT_HCA_VERSION_OFFSET) = INIT_HCA_VERSION;

-#if defined(_AMD64_)

+#ifndef _M_IX86

    *((u8 *) mailbox->buf + INIT_HCA_CACHELINE_SZ_OFFSET) = INIT_HCA_X86_64_BYTE_CACHELINE_SZ;

#endif


That's all for now; more to follow.

Stan.


From: Leonid Keller [mailto:leonid at mellanox.co.il]
Sent: Wednesday, October 05, 2011 9:42 AM
To: Smith, Stan
Cc: ofw_list
Subject: RE: New bus driver

Thanks.

I've made three more commits with missed files.
Now you are to be able to build it.

From: Smith, Stan [mailto:stan.smith at intel.com]
Sent: Wednesday, October 05, 2011 6:31 PM
To: Leonid Keller
Cc: ofw_list
Subject: RE: New bus driver

Thank you Leo, will investigate immediately.

Stan.

From: Leonid Keller [mailto:leonid at mellanox.co.il]
Sent: Wednesday, October 05, 2011 7:21 AM
To: Smith, Stan
Cc: ofw_list
Subject: New bus driver

Hi Stan,

I started commits related to new bus driver.
I created a new branch - mlx4 - on base of trunk:3283 and replaced \HW directory.
I also changed several files in order to build it.
I built it with
OFED\Bld1.bat win7 x64 all
And we are checking it now.

Patch 3287 contains a long comment describing main changes in the bus drivers.
You (and all) are invited to review the patch.
Don't hesitate to ask questions.

I'll continue to add more patches, related to other components.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20111008/490afbaa/attachment.html>