[ofw] Fix double free of MAD, M_Key check logic for caching.

Fab Tillier ftillier at microsoft.com
Mon Jun 18 18:18:52 PDT 2012


Subject says it all.

Signed-off-by: Fab Tillier <ftillier at microsoft.com>

Index: core/al/kernel/al_smi.c
===================================================================
--- core/al/kernel/al_smi.c	(revision 3414)
+++ core/al/kernel/al_smi.c	(working copy)
@@ -2181,7 +2181,7 @@
 		p_smp->mgmt_class == IB_MCLASS_SUBN_LID );
 
 	/* simple m-key check */
-	if( p_spl_qp_svc->m_key &&  p_smp->m_key == p_spl_qp_svc->m_key )
+	if( p_smp->m_key == p_spl_qp_svc->m_key )
 	{
 		if(!p_spl_qp_svc->cache_en )
 		{
@@ -2277,8 +2277,6 @@
 		status = get_resp_mad( p_spl_qp_svc, p_mad_wr, &p_mad_response );
 		if( status != IB_SUCCESS )
 		{
-			__complete_send_mad( p_spl_qp_svc->h_mad_disp, p_mad_wr,
-				IB_WCS_LOCAL_OP_ERR );
 			AL_EXIT( AL_DBG_SMI );
 			return status;
 		}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3.smi.patch
Type: application/octet-stream
Size: 724 bytes
Desc: 3.smi.patch
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20120619/1f642cc8/attachment.obj>


More information about the ofw mailing list