[ofw] librdmacm/rsocket compile failure for x86

[Hefty, Sean]

Hmmm -- I don't recall seeing any compile errors.  There must be some difference in our build environment.

I think I build win7 x86/x64 chk/fre and 2008.

changes look fine though

> -----Original Message-----
> From: ofw-bounces at lists.openfabrics.org [mailto:ofw-
> bounces at lists.openfabrics.org] On Behalf Of Smith, Stan
> Sent: Tuesday, February 05, 2013 2:09 PM
> To: hubert.schmitt at oce.com
> Cc: ofw at lists.openfabrics.org
> Subject: [ofw] librdmacm/rsocket compile failure for x86
> 
> x86 compile (free or checked) for librdmacm\ fails:
> 
> 
> 
> Compiling - src\cma_main.cpp
> 
> 1>errors in directory f:\openib-windows-svn\latest\gen1\trunk\ulp\librdmacm\src
> 
> 1>f:\openib-windows-svn\latest\gen1\trunk\ulp\librdmacm\src\cma_main.cpp(602) :
> 
> error C2664: 'int (SOCKET,PDWORD_PTR,LPINT)' : cannot convert parameter 2 from
> 'SOCKET *' to 'PDWORD_PTR'
> 
> 
> 
> 1>warnings in directory f:\openib-windows-
> svn\latest\gen1\trunk\ulp\librdmacm\src
> 
> 1>f:\openib-windows-svn\latest\gen1\trunk\ulp\librdmacm\src\cma_main.cpp(606) :
> warning C4018: '>' : signed/unsigned mismatch
> 
> 
> 
> 1>f:\openib-windows-svn\latest\gen1\trunk\ulp\librdmacm\src\cma_main.cpp(618) :
> 
> error C2664: 'int (SOCKET,PDWORD_PTR,LPINT)' : cannot convert parameter 2 from
> 'SOCKET *' to 'PDWORD_PTR'
> 
> 
> 
> 1>f:\openib-windows-svn\latest\gen1\trunk\ulp\librdmacm\src\cma_main.cpp(622)
> :warning C4018: '>' : signed/unsigned mismatch
> 
> 
> 
> 1>f:\openib-windows-svn\latest\gen1\trunk\ulp\librdmacm\src\cma_main.cpp(634) :
> 
> error C2664: 'int (SOCKET,PDWORD_PTR,LPINT)' : cannot convert parameter 2 from
> 'SOCKET *' to 'PDWORD_PTR'
> 
> 
> 
> 1>f:\openib-windows-svn\latest\gen1\trunk\ulp\librdmacm\src\cma_main.cpp(638)
> :warning C4018: '>' : signed/unsigned mismatch
> 
> 
> 
> Fixed by
> 
> casting to PDWORD_PTR
> 
> casting to (unsigned)
> 
> 
> 
> signed-off by stan smith (stan.smith at intel.com)
> 
> 
> 
> --- C:/Users/scsmith/AppData/Local/Temp/cma_main.cpp-revBASE.svn000.tmp.cpp
> Thu Jan 24 15:02:56 2013
> 
> +++ C:/Users/scsmith/Documents/openIB-
> windows/ofw/gen1/trunk/ulp/librdmacm/src/cma_main.cpp      Tue Feb 05 13:56:08
> 2013
> 
> @@ -597,13 +597,13 @@
> 
>            if (readfds->fd_array[i]) {
> 
>                  ret = gMainUpCallTable.lpWPUQuerySocketHandleContext(
> 
>                                     readfds->fd_array[i],
> 
> -                                   &rreadfds.fd_array[i],
> 
> +                                   (PDWORD_PTR)&rreadfds.fd_array[i],
> 
>                                    lpErrno
> 
>                              );
> 
>                  if (SOCKET_ERROR == ret)
> 
>                        return ret;
> 
> 
> 
> -                 if (rreadfds.fd_array[i] > nfds)
> 
> +                 if (rreadfds.fd_array[i] > (unsigned) nfds)
> 
>                        nfds = (int)rreadfds.fd_array[i];
> 
>                   rreadfds.fd_count++;
> 
> @@ -613,13 +613,13 @@
> 
>            if (writefds->fd_array[i]) {
> 
>                  ret = gMainUpCallTable.lpWPUQuerySocketHandleContext(
> 
>                                     writefds->fd_array[i],
> 
> -                                   &rwritefds.fd_array[i],
> 
> +                                   (PDWORD_PTR)&rwritefds.fd_array[i],
> 
>                                    lpErrno
> 
>                              );
> 
>                  if (SOCKET_ERROR == ret)
> 
>                        return ret;
> 
> -                 if (rwritefds.fd_array[i] > nfds)
> 
> +                 if (rwritefds.fd_array[i] > (unsigned) nfds)
> 
>                        nfds = (int)rwritefds.fd_array[i];
> 
>                   rwritefds.fd_count++;
> 
> @@ -629,13 +629,13 @@
> 
>            if (exceptfds->fd_array[i]) {
> 
>                  ret = gMainUpCallTable.lpWPUQuerySocketHandleContext(
> 
>                                     exceptfds->fd_array[i],
> 
> -                                   &rexceptfds.fd_array[i],
> 
> +                                   (PDWORD_PTR) &rexceptfds.fd_array[i],
> 
>                                    lpErrno
> 
>                              );
> 
>                  if (SOCKET_ERROR == ret)
> 
>                        return ret;
> 
> -                 if (rexceptfds.fd_array[i] > nfds)
> 
> +                 if (rexceptfds.fd_array[i] > (unsigned) nfds)
> 
>                        nfds = (int)rexceptfds.fd_array[i];
> 
>                   rexceptfds.fd_count++;
> 
>