[openib-general] Re: [PATCH] remove ts_kernel_trace from client_query*

[Roland Dreier]

    Tom> I still think having a CONFIG option to enable debugging in
    Tom> the first place would be a good idea as having to call a
    Tom> function and make a choice to print out or not (especially in
    Tom> the data path) will hurt performance.

I agree.  The model I like is what ALSA does: they have a
CONFIG_SND_DEBUG (as well as some suboptions), which (among other
things) makes files like /proc/asound/card0/pcm0p/xrun_debug show up.
The default debug level is 0, but if you echo 1 or 2 into the
xrun_debug file then more verbose debugging is enabled at runtime.

I'm probably making too big a deal out of the debug code design but
I guess I've spent too much time debugging IB code not to make a big
deal out of it :)

 - R.

PS Greg, I know we shouldn't put files in /proc, I was just describing
what ALSA does :)