[openib-general] Re: [PATCH] remove ts_kernel_trace from client_query*

[Grant Grundler]

[ still catching up from email while on vacation...this goose could
already be cooked... ]

On Wed, Aug 25, 2004 at 12:57:17PM -0700, Roland Dreier wrote:
>     Michael> Wouldnt compile-time be enough?  If you want to change
>     Michael> the setting, you could just add -DDEBUG or something in
>     Michael> the makefile and rebuild the relevant module.
> 
> We've found it very useful for debugging to be able to turn on debug
> output after a problem is detected without having to disturb the system.

It could be another one of the "CONFIG_EMBEDDED" options.

>     Michael> I'm not sure multiple debug levels are really useful -
>     Michael> from experience its hard to define in which debug level
>     Michael> each print belongs, so you end up enabling the maximum
>     Michael> verbosity, anyway.
> 
> Yes, I agree, although perhaps two levels (DEBUG and VERBOSEDEBUG say)
> might be useful.

I strongly prefer setting up the debug flags based on features.
Ie track memory usage with one flag, setup/tear down of connections
with another, etc.

grant