[openib-general] ib_mad.h GSI QP1 Well Known QKey

Sean Hefty mshefty at ichips.intel.com
Wed Aug 25 14:19:43 PDT 2004


On Wed, 25 Aug 2004 15:17:59 -0700
Roland Dreier <roland at topspin.com> wrote:

>     > #define IB_QP1		__cpu_to_be32(1)
> 
> Why use the __ form?  I think it should just be cpu_to_be32()

Agreed.
 
> By the way, I'm not looking forward to debugging everything if we
> switch our byte ordering convention for QPNs etc....

I don't want to debug host/network order issues either, which is why I think everything that appears in a MAD should be in network order.  Otherwise, we'll have a combination of host/network order values.



More information about the general mailing list