[openib-general] [PATCH] optional functions, ib_mad update

Roland Dreier roland at topspin.com
Wed Sep 1 17:36:38 PDT 2004


    Sean> Note that I didn't commit that last patch.  I wanted to get
    Sean> some other responses first.  The only optional calls that I
    Sean> did leave inline in my original tree were the CQ ones that I
    Sean> considered to be speed path operations.  I can easily just
    Sean> ignore my last patch, and I'm open either way here...

I don't think it's a big deal either way, but having non-data path
functions be inline makes ib_verbs.h messier and harder to read and
starts us down the path towards having bloated slow path functions
stay inline.  So I would vote not to commit this change.

 - R.



More information about the general mailing list