[openib-general] [PATCH] optional functions, ib_mad update

Grant Grundler iod00d at hp.com
Wed Sep 1 22:02:55 PDT 2004


On Wed, Sep 01, 2004 at 05:36:38PM -0700, Roland Dreier wrote:
> I don't think it's a big deal either way, but having non-data path
> functions be inline makes ib_verbs.h messier and harder to read and
> starts us down the path towards having bloated slow path functions
> stay inline.  So I would vote not to commit this change.


Roland,
"bloated slow path" makes sense to me too and answers my original question.
"messier and harder to read" - I don't buy that.

Since most are inlined currently, whoever commits the change please
add that comment about "bloated slow path" to the patch/commit that
changes "non-data path" inline functions to regular functions.
(then I promise I won't ask again :^)

thanks,
grant



More information about the general mailing list