[openib-general] Re: Re: calculate inline data size

[Michael S. Tsirkin]

Quoting r. Roland Dreier <rolandd at cisco.com>:
> Subject: Re: Re: calculate inline data size
> 
>     Michael> why dont you decide what size you want and use that?
> 
> I think we have a bug -- when we calculate the max_inline_data size,
> we don't take into account the fact that an RDMA write WQE will have a
> remote address segment.

Seems like it.

> I'm not sure what the best solution is here.  We can report
> max_inline_data as 16 bytes smaller to handle the RDMA case -- but
> this means someone doing sends only could actually post more inline
> data.

I expect generally size may be different for work requests
with and without immediate, so we'd need an array for each
possible opcode.

> Or we could split the cap field into max_inline_send_data and
> max_inline_rdma_write_data and report the two values separately.  But
> that may be too complicated to be worth it.
> 
>  - R.

I think its too complicated.

-- 
MST