[openib-general] Re: BUG ipoib oops in iptables/netfilter

Grant Grundler iod00d at hp.com
Wed Mar 30 13:24:43 PST 2005


On Wed, Mar 30, 2005 at 12:11:53PM -0800, Roland Dreier wrote:
>     Grant> Are you thinking of adding "get_unaligned()" or something else?
> 
> Just fixing the structs so they get the correct layout without any
> monkey business.

ah ok.

> I think I understand the problem, it's just a matter of fixing the
> code up to avoid the bogus stuff.  Just compare the ia64 assembly for
> the functions c() and d() in the code:
> 
>    struct foo { int a; };
>    struct bar { int b; } __attribute__((packed));
> 
>    int c(struct foo *x) { return x->a; }
>    int d(struct bar *x) { return x->b; }

d() is a mess. Got it.
In case anyone else is curious, I've parked the resulting
"gcc -S" (and gcc -S -O4) output on
	http:/iou.parisc-linux.org/~grundler/ia64-packed/

thanks,
grant



More information about the general mailing list