[PATCH] core/addr: fix compilation warning {was Re:[openib-general] Latest build test results}

Nishanth Aravamudan nacc at us.ibm.com
Mon Oct 17 12:01:40 PDT 2005


On 17.10.2005 [10:54:21 -0700], Roland Dreier wrote:
>     Sean> Does anyone know the reason for this change?
> 
> From the git tree, I can tell you that the change is from the commit:
> 
>     diff-tree f2ccd8fa06c8e302116e71df372f5c1f83432e03 (from b6b99eb5409d75ae35390057cd28f3aedfbd4cf4)
>     Author: David S. Miller <davem at davemloft.net>
>     Date:   Tue Aug 9 19:34:12 2005 -0700
>     
>         [NET]: Kill skb->real_dev
>     
>         Bonding just wants the device before the skb_bond()
>         decapsulation occurs, so simply pass that original
>         device into packet_type->func() as an argument.
>     
>         It remains to be seen whether we can use this same
>         exact thing to get rid of skb->input_dev as well.
>     
>         Signed-off-by: David S. Miller <davem at davemloft.net>
> 
> it looks like the networking stack now passes the real device into
> packet_type.func as orig_dev, rather than having the function look at
> skb->real_dev.

So, if I understand David's comment correctly, it's a structure size
reduction and a small API change? That probably means we've caught all
the bugs that exist right now (compilation wise), as I'm not seeing any
in the svn kernel tree with the handful of patches in this thread. And I
guess there are any users of real_dev in the tree that we need to worry
about, as those would have spat warnings too.

Thanks,
Nish



More information about the general mailing list