[openib-general][patch review] srp: fmr implementation,

Roland Dreier rdreier at cisco.com
Fri Apr 14 09:04:25 PDT 2006


Hmm, I don't understand what could be going on.  srp_send_tsk_mgmt()
currently has:

	if (req->cmd_done) {
		srp_remove_req(target, req, req_index);
		scmnd->scsi_done(scmnd);
	} else if (!req->tsk_status) {
		srp_remove_req(target, req, req_index);
		scmnd->result = DID_ABORT << 16;
		ret = SUCCESS;
	}

and otherwise it returns FAILED.  So in both cases where it finishes
the command, it removes it from the list of pending requests.

Are you absolutely sure you saw the crash with a patched driver that
has that code in srp_send_tsk_mgmt()?

 - R.



More information about the general mailing list