[openib-general][patch review] srp: fmr implementation,

Vu Pham vuhuong at mellanox.com
Fri Apr 14 09:55:51 PDT 2006


Roland Dreier wrote:
> Hmm, I don't understand what could be going on.  srp_send_tsk_mgmt()
> currently has:
> 
> 	if (req->cmd_done) {
> 		srp_remove_req(target, req, req_index);
> 		scmnd->scsi_done(scmnd);
> 	} else if (!req->tsk_status) {
> 		srp_remove_req(target, req, req_index);
> 		scmnd->result = DID_ABORT << 16;
> 		ret = SUCCESS;
> 	}
> 
> and otherwise it returns FAILED.  So in both cases where it finishes
> the command, it removes it from the list of pending requests.
> 
> Are you absolutely sure you saw the crash with a patched driver that
> has that code in srp_send_tsk_mgmt()?

I'm sure that I patched srp driver revision 6036. It has the 
above code in srp_send_tsk_mgmt()

I don't have time to work on this today. I'll get back with 
more debug details on Monday

Thanks,
Vu



More information about the general mailing list