[openib-general] [PATCH] osm: fix a bug in ignroing pending transaction of Light Sweep

Hal Rosenstock halr at voltaire.com
Mon Dec 18 07:11:58 PST 2006


Hi Eitan,

On Sat, 2006-12-16 at 13:56, Eitan Zahavi wrote:
> Hi Hal
> 
> This patch provides fixes an issue discovered by the nightly regression.
> OpenSM state machine got stack due to pending SwitchInfo transaction 
> being ignored since one of the queries for SwitchInfo
> failed (due to bad-link).
> The patch below simply avoids aborting the wait for all SwitchInfo 
> requests to return.
> 
> I think this issue might have hurt us in other situations too sine it 
> aborted the wait on "CHANGE DETECTED" too.
> CHANGE_DETECTED is fired on the first switch that reported "Change Bit".
> 
> It is possible that the issue is showing up as we added incremental 
> support (e.g. for routing)
> Since only of there are no other SMP's sent during the heavy sweep we 
> will get the
> "NO_PENDING_TRANSACTIONS" signal caused by the SwitchInfo requests

So is the same issue applicable to OFED 1.1 ?

> Eitan
> 
> Signed-off-by:  Eitan Zahavi <eitan at mellanox.co.il >
> 
>  osm/opensm/osm_state_mgr.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)

Thanks. Applied.

-- Hal





More information about the general mailing list